Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

disable step logging in epoch hooks #10409

Merged
merged 4 commits into from
Nov 9, 2021
Merged

disable step logging in epoch hooks #10409

merged 4 commits into from
Nov 9, 2021

Conversation

rohitgr7
Copy link
Contributor

@rohitgr7 rohitgr7 commented Nov 8, 2021 •
edited
Loading

What does this PR do?

Disable step logging on epoch hooks. Currently self.log(on_step=True) is supported for *_epoch_start hooks but not for *_epoch_end hooks. Logging on step level in epoch level hooks doesn't make sense.
Confirmed with @carmocca

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

@rohitgr7 rohitgr7 added the bug Something isn't working label Nov 8, 2021
@rohitgr7 rohitgr7 added this to the 1.5.x milestone Nov 8, 2021
@rohitgr7 rohitgr7 marked this pull request as ready for review November 8, 2021 14:26
@github-actions
Copy link
Contributor

github-actions bot commented Nov 8, 2021

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

carmocca
carmocca approved these changes Nov 8, 2021
View reviewed changes
Copy link
Contributor

@carmocca carmocca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test failures

awaelchli
awaelchli reviewed Nov 8, 2021
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@github-actions
Copy link
Contributor

github-actions bot commented Nov 8, 2021

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@awaelchli awaelchli added the logging Related to the `LoggerConnector` and `log()` label Nov 8, 2021
rohitgr7
rohitgr7 commented Nov 8, 2021
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@mergify mergify bot added the ready PRs ready to be merged label Nov 9, 2021
@justusschock justusschock enabled auto-merge (squash) November 9, 2021 09:47
@justusschock justusschock merged commit 21eafaf into master Nov 9, 2021
@justusschock justusschock deleted the fix/epoch_meth_step_log branch November 9, 2021 11:23
rohitgr7 added a commit that referenced this pull request Nov 9, 2021
@rohitgr7
disable step logging in epoch hooks (#10409)
3ba3346 
* disable step logging in epoch hooks

* chlog

* Apply suggestions from code review

* chlog
awaelchli pushed a commit that referenced this pull request Nov 9, 2021
@rohitgr7 @awaelchli
disable step logging in epoch hooks (#10409)
9ad69ab 
* disable step logging in epoch hooks

* chlog

* Apply suggestions from code review

* chlog
lexierule pushed a commit that referenced this pull request Nov 9, 2021
@rohitgr7 @lexierule
disable step logging in epoch hooks (#10409)
8d7712c 
* disable step logging in epoch hooks

* chlog

* Apply suggestions from code review

* chlog
Raalsky pushed a commit to neptune-ai/pytorch-lightning that referenced this pull request Nov 23, 2021
@rohitgr7 @Raalsky
disable step logging in epoch hooks (Lightning-AI#10409)
abd7062 
* disable step logging in epoch hooks

* chlog

* Apply suggestions from code review

* chlog
@rohitgr7 rohitgr7 mentioned this pull request Feb 7, 2022
Closed
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kaushikb11 kaushikb11 kaushikb11 approved these changes

@justusschock justusschock justusschock approved these changes

@carmocca carmocca carmocca approved these changes

@Borda Borda Awaiting requested review from Borda Borda is a code owner

@SeanNaren SeanNaren Awaiting requested review from SeanNaren

@tchaton tchaton Awaiting requested review from tchaton tchaton is a code owner

@williamFalcon williamFalcon Awaiting requested review from williamFalcon

@awaelchli awaelchli Awaiting requested review from awaelchli

Assignees
No one assigned
Labels
bug Something isn't working logging Related to the `LoggerConnector` and `log()` ready PRs ready to be merged
Projects
None yet
Milestone
pl:1.5.x
Development

Successfully merging this pull request may close these issues.
5 participants
@rohitgr7 @awaelchli @carmocca @justusschock @kaushikb11