Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lightning 1.5 release #10306

Merged
merged 4 commits into from
Nov 2, 2021
Merged

Lightning 1.5 release #10306

merged 4 commits into from
Nov 2, 2021

Conversation

awaelchli
Copy link
Contributor

@awaelchli awaelchli commented Nov 2, 2021

What does this PR do?

Updates the changelog and several attributes in preparation of the 1.5 release.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

I made sure I had fun coding 🙃

Part of #1 (it's a lie, this is just here to avoid noisy GitHub bot)

@github-actions
Copy link
Contributor

github-actions bot commented Nov 2, 2021

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

Copy link
Member

@Borda Borda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 🐰

@awaelchli awaelchli added this to the v1.5 milestone Nov 2, 2021
@awaelchli awaelchli marked this pull request as ready for review November 2, 2021 15:29
@mergify mergify bot added the ready PRs ready to be merged label Nov 2, 2021
@codecov
Copy link

codecov bot commented Nov 2, 2021

Codecov Report

Merging #10306 (76cb77e) into master (373c32e) will not change coverage.
The diff coverage is 100%.

❗ Current head 76cb77e differs from pull request most recent head f2b81f0. Consider uploading reports for the commit f2b81f0 to get more accurate results

@@           Coverage Diff           @@
##           master   #10306   +/-   ##
=======================================
  Coverage      93%      93%           
=======================================
  Files         182      182           
  Lines       16487    16487           
=======================================
  Hits        15256    15256           
  Misses       1231     1231           

Copy link
Contributor

@akihironitta akihironitta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lexierule lexierule merged commit 073b735 into master Nov 2, 2021
@lexierule lexierule deleted the 1.5-release branch November 2, 2021 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation related ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants