Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CLI] Shorthand notation to instantiate datamodules #10011

Merged
merged 5 commits into from
Oct 20, 2021

Conversation

carmocca
Copy link
Contributor

What does this PR do?

Fixes #7250

Does your PR introduce any breaking changes? If yes, please list them.

None

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

@carmocca carmocca added feature Is an improvement or enhancement data handling Generic data-related topic argparse (removed) Related to argument parsing (argparse, Hydra, ...) labels Oct 19, 2021
@carmocca carmocca added this to the v1.5 milestone Oct 19, 2021
@carmocca carmocca self-assigned this Oct 19, 2021
@codecov
Copy link

codecov bot commented Oct 19, 2021

Codecov Report

Merging #10011 (5b31406) into master (e0c83ee) will increase coverage by 0%.
The diff coverage is 100%.

@@           Coverage Diff           @@
##           master   #10011   +/-   ##
=======================================
  Coverage      93%      93%           
=======================================
  Files         180      180           
  Lines       15877    15882    +5     
=======================================
+ Hits        14698    14703    +5     
  Misses       1179     1179           

pytorch_lightning/utilities/cli.py Outdated Show resolved Hide resolved
@mergify mergify bot added the ready PRs ready to be merged label Oct 19, 2021
tests/utilities/test_cli.py Show resolved Hide resolved
@carmocca carmocca enabled auto-merge (squash) October 20, 2021 00:09
@carmocca carmocca merged commit ad8d6c8 into master Oct 20, 2021
@carmocca carmocca deleted the cli/shorthand-datamodule branch October 20, 2021 00:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
argparse (removed) Related to argument parsing (argparse, Hydra, ...) data handling Generic data-related topic feature Is an improvement or enhancement ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Extend the LightningCLI to register models, datamodules, and callbacks.
4 participants