Skip to content

Change LightningCLI tests to account for future fix in jsonargparse #29356

Change LightningCLI tests to account for future fix in jsonargparse

Change LightningCLI tests to account for future fix in jsonargparse #29356

Triggered via pull request November 12, 2024 22:10
Status Success
Total duration 22s
Artifacts

probot-auto-cc.yml

on: pull_request
Fit to window
Zoom out
Zoom in

Annotations

2 errors and 1 warning
auto-cc
Resource not accessible by integration { name: 'HttpError', id: '11806584329', status: 403, response: { url: 'https://api.github.com/repos/Lightning-AI/pytorch-lightning/pulls/20372', status: 403, headers: { 'access-control-allow-origin': '*', 'access-control-expose-headers': 'ETag, Link, Location, Retry-After, X-GitHub-OTP, X-RateLimit-Limit, X-RateLimit-Remaining, X-RateLimit-Used, X-RateLimit-Resource, X-RateLimit-Reset, X-OAuth-Scopes, X-Accepted-OAuth-Scopes, X-Poll-Interval, X-GitHub-Media-Type, X-GitHub-SSO, X-GitHub-Request-Id, Deprecation, Sunset', connection: 'close', 'content-encoding': 'gzip', 'content-security-policy': "default-src 'none'", 'content-type': 'application/json; charset=utf-8', date: 'Tue, 12 Nov 2024 22:10:38 GMT', 'referrer-policy': 'origin-when-cross-origin, strict-origin-when-cross-origin', server: 'github.com', 'strict-transport-security': 'max-age=31536000; includeSubdomains; preload', 'transfer-encoding': 'chunked', vary: 'Accept-Encoding, Accept, X-Requested-With', 'x-accepted-github-permissions': 'pull_requests=write', 'x-content-type-options': 'nosniff', 'x-frame-options': 'deny', 'x-github-api-version-selected': '2022-11-28', 'x-github-media-type': 'github.v3; format=json', 'x-github-request-id': '0583:36819:296917B:50BDE14:6733D25E', 'x-ratelimit-limit': '15000', 'x-ratelimit-remaining': '14910', 'x-ratelimit-reset': '1731452495', 'x-ratelimit-resource': 'core', 'x-ratelimit-used': '90', 'x-xss-protection': '0' }, data: { message: 'Resource not accessible by integration', documentation_url: 'https://docs.github.com/rest/pulls/pulls#update-a-pull-request', status: '403' } }, request: { method: 'PATCH', url: 'https://api.github.com/repos/Lightning-AI/pytorch-lightning/pulls/20372', headers: { accept: 'application/vnd.github.v3+json', 'user-agent': 'probot/12.2.5 octokit-core.js/3.6.0 Node.js/20.13.1 (linux; x64)', authorization: 'token [REDACTED]', 'content-type': 'application/json; charset=utf-8' }, body: '{"body":"## What does this PR do?\\r\\n\\r\\nIt didn\'t make sense that in configs parameters with class type have the `class_path` and `init_args` structure, but callables that return a class instance don\'t. This will be fixed in the next release of jsonargparse. This pull request changes a couple of `LightningCLI` unit tests so that once the new jsonargparse release comes out, the lightning tests don\'t start failing.\\r\\n\\r\\n<!-- Does your PR introduce any breaking changes? If yes, please list them. -->\\r\\n\\r\\n<details>\\r\\n <summary><b>Before submitting</b></summary>\\r\\n\\r\\n- Was this **discussed/agreed** via a GitHub issue? (not for typos and docs)\\r\\n- [x] Did you read the [contributor guideline](https://github.com/Lightning-AI/lightning/blob/master/.github/CONTRIBUTING.md), **Pull Request** section?\\r\\n- [x] Did you make sure your **PR does only one thing**, instead of bundling different changes together?\\r\\n- Did you make sure to **update the documentation** with your changes? (if necessary)\\r\\n- Did you write any **new necessary tests**? (not for typos and docs)\\r\\n- [x] Did you verify new and **existing tests pass** locally with your changes?\\r\\n- Did you list all the **breaking changes** introduced by this pull request?\\r\\n- Did you **update the CHANGELOG**? (not for typos, docs, test updates, or minor internal changes/refactors)\\r\\n\\r\\n<!-- In the CHANGELOG, separate each item in the unreleased section by a blank line to reduce collisions -->\\r\\n\\r\\n</details>\\r\\n\\r\\n## PR review\\r\\n\\r\\nAnyone in the community is welcome to review the PR.\\r\\nBefore you start reviewing, make sure you have read the [review guidelines](https://github.com/Lightning-AI/lightning/wiki/Review-guidelines). In short, see the following bullet-list:\\r\\n\\r\\n<details>\\r\\n <summary>Reviewer checklist</summary>\\
auto-cc
HttpError: Resource not accessible by integration at /home/runner/work/_actions/Lightning-AI/probot/v1/node_modules/@octokit/core/node_modules/@octokit/request/dist-node/index.js:86:21 at process.processTicksAndRejections (node:internal/process/task_queues:95:5) at async Job.doExecute (/home/runner/work/_actions/Lightning-AI/probot/v1/node_modules/bottleneck/light.js:405:18) { name: 'AggregateError', event: { id: '11806584329', name: 'pull_request', payload: { action: 'labeled', enterprise: { avatar_url: 'https://avatars.githubusercontent.com/b/230529?v=4', created_at: '2024-09-24T13:06:23Z', description: null, html_url: 'https://github.com/enterprises/Lightning-AI', id: 230529, name: 'Lightning-AI', node_id: 'E_kgDOAAOEgQ', slug: 'Lightning-AI', updated_at: '2024-10-16T18:39:41Z', website_url: null }, label: { color: '848DD1', default: false, description: 'pl.cli.LightningCLI', id: 3548589830, name: 'lightningcli', node_id: 'LA_kwDOCqWgoM7Tgy8G', url: 'https://api.github.com/repos/Lightning-AI/pytorch-lightning/labels/lightningcli' }, number: 20372, organization: { avatar_url: 'https://avatars.githubusercontent.com/u/58386951?v=4', description: 'Turn ideas into AI, Lightning fast. Creators of PyTorch Lightning, Lightning AI Studio, TorchMetrics, Fabric, Lit-GPT, Lit-LLaMA', events_url: 'https://api.github.com/orgs/Lightning-AI/events', hooks_url: 'https://api.github.com/orgs/Lightning-AI/hooks', id: 58386951, issues_url: 'https://api.github.com/orgs/Lightning-AI/issues', login: 'Lightning-AI', members_url: 'https://api.github.com/orgs/Lightning-AI/members{/member}', node_id: 'MDEyOk9yZ2FuaXphdGlvbjU4Mzg2OTUx', public_members_url: 'https://api.github.com/orgs/Lightning-AI/public_members{/member}', repos_url: 'https://api.github.com/orgs/Lightning-AI/repos', url: 'https://api.github.com/orgs/Lightning-AI' }, pull_request: { _links: { comments: { href: 'https://api.github.com/repos/Lightning-AI/pytorch-lightning/issues/20372/comments' }, commits: { href: 'https://api.github.com/repos/Lightning-AI/pytorch-lightning/pulls/20372/commits' }, html: { href: 'https://github.com/Lightning-AI/pytorch-lightning/pull/20372' }, issue: { href: 'https://api.github.com/repos/Lightning-AI/pytorch-lightning/issues/20372' }, review_comment: { href: 'https://api.github.com/repos/Lightning-AI/pytorch-lightning/pulls/comments{/number}' }, review_comments: { href: 'https://api.github.com/repos/Lightning-AI/pytorch-lightning/pulls/20372/comments' }, self: { href: 'https://api.github.com/repos/Lightning-AI/pytorch-lightning/pulls/20372' }, statuses: { href: 'https://api.github.com/repos/Lightning-AI/pytorch-lightning/statuses/fcf98052c55b53251dc2155d0ed1022b70957c65' } }, active_lock_reason: null, additions: 32, assignee: null, assignees: [], author_association: 'CONTRIBUTOR', auto_merge: null, base: { label: 'Lightning-AI:master', ref: 'master', repo: { allow_auto_merge: false, allow_forking: true, allow_merge_commit: false, allow_rebase_merge: true, allow_squash_merge: true, allow_update_branch: true, archive_url: 'https://api.github.com/repos/Lightning-AI/pytorch-lightning/{archive_format}{/ref}', archived: false, assignees_url: 'https://api.github.com/repos/Lightning-AI/pytorch-lightning/assignees{/user}', blobs_url: 'https://api.github.com/repos/Lightni
auto-cc
The following actions use a deprecated Node.js version and will be forced to run on node20: Lightning-AI/probot@v1. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/