Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add plotting 8/n #1605

Merged
merged 4 commits into from
Mar 10, 2023
Merged

Add plotting 8/n #1605

merged 4 commits into from
Mar 10, 2023

Conversation

SkafteNicki
Copy link
Member

What does this PR do?

Fixes part of #1406
Add plotting to a few more metrics (regression)

Before submitting
  • Was this discussed/agreed via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?
PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@SkafteNicki SkafteNicki added the enhancement New feature or request label Mar 10, 2023
@SkafteNicki SkafteNicki added this to the v0.12 milestone Mar 10, 2023
@codecov
Copy link

codecov bot commented Mar 10, 2023

Codecov Report

Merging #1605 (5a3cc0a) into master (632e8e6) will decrease coverage by 0%.
The diff coverage is 86%.

Additional details and impacted files
@@          Coverage Diff           @@
##           master   #1605   +/-   ##
======================================
- Coverage      88%     88%   -0%     
======================================
  Files         226     226           
  Lines       11992   12029   +37     
======================================
+ Hits        10601   10632   +31     
- Misses       1391    1397    +6     

@mergify mergify bot added the ready label Mar 10, 2023
@mergify mergify bot requested a review from a team March 10, 2023 10:57
@Borda Borda enabled auto-merge (squash) March 10, 2023 10:58
@Borda Borda merged commit 2d21f6f into master Mar 10, 2023
@Borda Borda deleted the plot/reg branch March 10, 2023 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request ready
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants