Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not install unnecessary dependencies #410

Merged
merged 4 commits into from
Aug 15, 2023
Merged

Conversation

carmocca
Copy link
Contributor

Fixes #323
Fixes #278

Most of our dependencies are optional. Do not include them in our requirements.txt

@carmocca carmocca requested a review from awaelchli as a code owner August 15, 2023 09:07
@carmocca carmocca self-assigned this Aug 15, 2023
@carmocca carmocca requested a review from lantiga as a code owner August 15, 2023 09:07
@Andrei-Aksionov
Copy link
Collaborator

Don't know, maybe this question was asked before, but why does this repo uses only requirements.txt and not poetry. There is in-build functionality to separate essential and optional packages.
Given that PyTorch-Lightning uses poetry I assume that there should be a particular reason to not use it here. Maybe for simplicity?

@carmocca
Copy link
Contributor Author

Yes, it's for simplicity

@carmocca carmocca merged commit fdc142b into main Aug 15, 2023
@carmocca carmocca deleted the carmocca/optional-deps branch August 15, 2023 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adding Windows native support bitsandbytes No longer supported on Windows.
3 participants