Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct an apparent logger output directory bug #1232

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
+2 −2
Open

Correct an apparent logger output directory bug #1232

Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
20e38a7
Add file
yutsai84 Apr 2, 2024
96b1609
Supplies default value to pass the tests
yutsai84 Apr 2, 2024
23d4e9b
Update litgpt/utils.py
yutsai84 Apr 2, 2024
53008ac
Merge branch 'Lightning-AI:main' into correct-output-name
yutsai84 Apr 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions litgpt/utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -445,15 +445,15 @@ def parse_devices(devices: Union[str, int]) -> int:
def choose_logger(
logger_name: Literal["csv", "tensorboard", "wandb"],
out_dir: Path,
name: str,
name: str = "csv",
yutsai84 marked this conversation as resolved.
Show resolved Hide resolved
log_interval: int = 1,
resume: Optional[bool] = None,
**kwargs: Any,
):
if logger_name == "csv":
return CSVLogger(root_dir=(out_dir / "logs"), name="csv", flush_logs_every_n_steps=log_interval, **kwargs)
return CSVLogger(root_dir=(out_dir / "logs"), name=name, flush_logs_every_n_steps=log_interval, **kwargs)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like to point out that "name" that is passed in is not conceptually the same as "name" argument of the logger, it's used differently to make a simplified directory structure. And so the choice here was deliberate (by me). With the change in this PR, there will now be essentially twice the name in the directory structure, which is what I wanted to avoid.

if logger_name == "tensorboard":
return TensorBoardLogger(root_dir=(out_dir / "logs"), name="tensorboard", **kwargs)
return TensorBoardLogger(root_dir=(out_dir / "logs"), name=name, **kwargs)
if logger_name == "wandb":
return WandbLogger(project=name, resume=resume, **kwargs)
raise ValueError(f"`--logger_name={logger_name}` is not a valid option. Choose from 'csv', 'tensorboard', 'wandb'.")
Loading