Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: Parquet support PR #460

Merged
merged 1 commit into from
Feb 6, 2025

Conversation

deependujha
Copy link
Collaborator

Before submitting
  • Was this discussed/agreed via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?

What does this PR do?

This PR addresses the feedback and suggestions provided in the review for PR #443 after its merge.

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in GitHub issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

Copy link

codecov bot commented Feb 4, 2025

Codecov Report

Attention: Patch coverage is 20.00000% with 4 lines in your changes missing coverage. Please review.

Project coverage is 78%. Comparing base (7cbb3ef) to head (6f86e35).
Report is 4 commits behind head on main.

❌ Your patch status has failed because the patch coverage (20%) is below the target coverage (50%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@         Coverage Diff         @@
##           main   #460   +/-   ##
===================================
  Coverage    78%    78%           
===================================
  Files        37     37           
  Lines      5365   5368    +3     
===================================
+ Hits       4182   4192   +10     
+ Misses     1183   1176    -7     

@bhimrazy
Copy link
Collaborator

bhimrazy commented Feb 6, 2025

@deependujha,
Would it be beneficial to also include a test case for images and also different data types check, or would that be redundant?

@tchaton tchaton merged commit c6edaa7 into Lightning-AI:main Feb 6, 2025
28 of 29 checks passed
@deependujha deependujha deleted the refactor/parquet-support-pr branch February 6, 2025 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants