Fix socket

[thatstoasty]

No description provided.

[thatstoasty]

I'm moving stuff to URI and also reworking the uri parsing to be a bit more thorough. Do you know what uri.request_uri is supposed to represent? Not sure exactly what request_uri is. It seems to encompass the path, the query string, and potential fragments?

I just changed it to be the full request uri, as in the original uri, since that made more sense given the name. But some guidance would help!

[saviorand]

@thatstoasty request_uri was originally supposed to be the uri from the first line of the http request, not 100% sure we stick to that though. We can change it no problem if you have a better solution, it's not important that it stays that way

[thatstoasty]

Gotcha, I'm working on the URI parsing right now so I'll fix the request_uri so it's back to what it was soon 👍🏾

[thatstoasty]

@izo0x90 @saviorand Please check out the changes! I was also working on updating the URI logic by switching to a byte reader instead of allocating new strings by splitting the initial uri provided. I tried to combine our changes, the tests should be passing now. There's a bit of duplication in the constants, so let me know if you want me to switch to using the Query param constants instead of the Constant struct I added!

[thatstoasty]

@saviorand Also thoughts on the client assuming port 80 if not specified? Or expect a port to be specified?

[saviorand]

@thatstoasty port 80 definitely makes sense, later when we add SSL support might also do 443

[izo0x90]

@thatstoasty awesome changes making things more performant 🔥

[thatstoasty]

Thanks for the feedback! I removed the constants struct to use existing ones, and set the port to default to 80 if http and 443 if https.

[saviorand]

Let's mergeee