H5I assert and seg fault bug fixes #30
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KLofthus
requested review from
fortnern,
jhendersonHDF and
mattjala
as code owners
mattjala
reviewed
Dec 24, 2024
mattjala
reviewed
Dec 24, 2024
mattjala
reviewed
Dec 24, 2024
mattjala
reviewed
Dec 24, 2024
mattjala
reviewed
Dec 24, 2024
mattjala
reviewed
Dec 24, 2024
mattjala
reviewed
Dec 24, 2024
mattjala
reviewed
Dec 24, 2024
mattjala
reviewed
Dec 24, 2024
mattjala
reviewed
Dec 24, 2024
mattjala
reviewed
Dec 24, 2024
mattjala
reviewed
Dec 24, 2024
mattjala
reviewed
Dec 24, 2024
mattjala
reviewed
Dec 24, 2024
mattjala
reviewed
Dec 24, 2024
mattjala
reviewed
Dec 24, 2024
mattjala
reviewed
Dec 24, 2024
|
The H5P changes seem unrelated to the H5I fix. Could they be moved into a different PR/branch so that the H5I fix can go in separately? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed the H5I id and type free lists from using the length of the free list to determine number of reallocable entries to using serial numbers entries get upon entry to the free list. A maximum allocable serial number in the global struct H5I_mt_g is used as the barrier to prevent entry serial numbers above that maximum to not be re-allocatable.
Stats variables in H5Ipkg.h that used the number reallocable were removed and serial number tracking stats were added.
In mt_id_test.c asserts that checked number reallocable adjustments were removed and asserts that checked serial number adjustments were added.