Skip to content
This repository has been archived by the owner on Feb 15, 2022. It is now read-only.

Fixes Inability to Tap Screenshot on iOS 14 #277

Merged

Conversation

mliberatore
Copy link
Contributor

@mliberatore mliberatore commented Sep 11, 2020

Closes #276

What It Does

When building / deploying for iOS 14, tapping the screenshot button wasn’t working. This is due to the fact that the contents of the cell were beneath the cell’s content view, which was getting the touch events. This didn’t seem to bite us until iOS 14, but the fix is just to properly add / pin to the cell’s content view. I checked the other cell, CheckmarkCell to be certain, and we’re not adding subviews there, so no similar issue exists.

How to Test

On iOS 11, 12, 13, 14:

  1. Launch the example app.
  2. Tap the screenshot.
  3. See the editor.

Notes

N/A

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@mliberatore mliberatore merged commit cfbb391 into master Sep 11, 2020
@mliberatore mliberatore deleted the fixes-inability-to-tap-screenshot-on-feedback-vc branch September 11, 2020 21:45
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to Tap Screenshot from FeedbackViewController (iOS 14)
2 participants