Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds Convenience RequestStateController #9

Merged
merged 3 commits into from
Aug 30, 2022
Merged

Adds Convenience RequestStateController #9

merged 3 commits into from
Aug 30, 2022

Conversation

Twigz
Copy link
Member

@Twigz Twigz commented Aug 30, 2022

What it Does

Adds a NetworkRequestStateController that adds a repeatable pattern for making a network request and receiving state updates about it.

@Twigz Twigz requested a review from mliberatore August 30, 2022 19:40
mliberatore
mliberatore approved these changes Aug 30, 2022
View reviewed changes
Copy link
Contributor

@mliberatore mliberatore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome. One naming suggestion

Sources/Networking/NetworkRequestStateController.swift Outdated Show resolved Hide resolved
@Twigz Twigz merged commit 0ed53ac into main Aug 30, 2022
@Twigz Twigz deleted the feature/add-request-state-controller branch August 30, 2022 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mliberatore mliberatore mliberatore approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Twigz @mliberatore