Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set bandwidth minimums to 1M for CRM/NMS integrations #640

Merged
merged 12 commits into from
Feb 24, 2025

Conversation

rchac
Copy link
Member

@rchac rchac commented Feb 18, 2025

By default, the LibreQoS integrations set the minimum rates of Circuits to match their maximum rates. The problem with this is that that guarantees HTB over-subscription - leading to Nodes for APs and Sites going over their limits regularly. To fix this, this PR sets all circuits (except infrastructure) to a minimum of 1 Mbps. That way, it becomes extremely unlikely to oversubscribe the HTB minimums.

This not only prevents APs and Sites from exceeding maximums, it also allows for more steady throughput to those nodes.

@rchac rchac requested a review from thebracket February 18, 2025 02:05
@rchac rchac added this to the v1.5 & v2.0 milestone Feb 18, 2025
@rchac rchac changed the title Set bandwidth minimums to 0M for CRM/NMS integrations Set bandwidth minimums to 1M for CRM/NMS integrations Feb 18, 2025
Copy link
Collaborator

@thebracket thebracket left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't look like it needs any config, either - so it looks good to me.

@rchac rchac merged commit 5a93bb5 into develop Feb 24, 2025
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants