Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor search to use rtk #376

Merged
merged 1 commit into from
Oct 31, 2023
Merged

refactor search to use rtk #376

merged 1 commit into from
Oct 31, 2023

Conversation

sickelap
Copy link
Contributor

  • Make search to work using RTK only
  • Set search query in URI. Makes it simpler and allows for deep-linking.
  • Add tests for photo reducer
  • Remove unused code
  • Fix ESLint errors for affected files

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
1.2% 1.2% Duplication

@derneuere derneuere merged commit 62b9d66 into LibrePhotos:dev Oct 31, 2023
1 check passed
@sickelap sickelap deleted the refactor_search_to_use_rtk branch October 31, 2023 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sickelap @derneuere