Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

curl: fix building debug #9609

Merged
merged 1 commit into from
Dec 23, 2024
Merged

curl: fix building debug #9609

merged 1 commit into from
Dec 23, 2024

Conversation

mglae
Copy link
Contributor

@mglae mglae commented Dec 22, 2024

Fix #9607

@heitbaum heitbaum mentioned this pull request Dec 23, 2024
Closed
@heitbaum
Copy link
Contributor

Fix #9607

Works fine. I have submitted it upstream with the addition of added -Winline back if not a debug build? Hopefully this or a variant is upstreamed then an update to package.mk

@chewitt chewitt merged commit a39f104 into LibreELEC:master Dec 23, 2024
@heitbaum
Copy link
Contributor

This is now committed upstream : curl/curl@c80c399

@mglae mglae deleted the le13_curl_debug branch December 24, 2024 09:19
@mglae
Copy link
Contributor Author

mglae commented Dec 24, 2024

Great.

When looking again it was the combination of PICKY_COMPILER=ON (default) and CURL_WERROR=ON (our choice). With any negated the build should succeed (not tested).

It's good for now, patch can be dropped after bump.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chewitt chewitt chewitt approved these changes

Assignees
No one assigned
Labels
BUGFIX BUILDSYSTEM LE 13.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] curl does not build on arm/aarch when LE is built with DEBUG
3 participants
@mglae @heitbaum @chewitt