-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
linux: enable silead touchscreen driver modules for generic #8476
Conversation
@stpf99 no problem to add support for the driver, but some changes needed:
If there is future demand for lots more firmwares we can switch to using a gsl-firmware package, but until that happens we should avoid bloating the image by adding lots of firmwares that won't be used. NB: If we did use a package we would use the original upstream repo and not a fork that has no differences (release tags aren't required for downloading, we use the latest githash for |
Hi. fw file for only my device is in LibreELEC/misc-firmware#9 ,i contributed this firmware and config to linux 6.6-rc , first to fw gsl repository and next to mailinglist and systemd quirks for rotation |
Please squash the [five] commits to a single commit and rename the single commit (not the pull-request) to |
NB: I don't see the firmware in the upstream linux-firmware repo: https://git.kernel.org/pub/scm/linux/kernel/git/firmware/linux-firmware.git/tree/ - can you please provide a link to the mailing list discussion? |
by now sorry but i cannot push to github by cmdline |
libreelec can overlay firmware from /storage/.config/firmware/silead directory for this fw, so only including modules should be enough and some information on howto site for users or on forum with tablet devices which uses silead |
i prepared test img for this modules, silead.ko i have in image but touchscreen_dmi.ko not , i have question about https://www.kernelconfig.io/config_touchscreen_dmi , should all Depends and Selects must be listed in linux.x86_64.conf , and depends and selects for each one from any above parents must be listed ??? and this should be in proper places ? and i think manually editing config is probably not proper way ? |
i prepared new linux.x86_64.conf by "make menuconfig" |
@@ -1,8 +1,8 @@ | |||
# | |||
# Automatically generated file; DO NOT EDIT. | |||
# Linux/x86 6.6.0-rc5 Kernel Configuration | |||
# Linux/x86 6.6.7 Kernel Configuration |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
drop this change
# | ||
CONFIG_CC_VERSION_TEXT="x86_64-libreelec-linux-gnu-gcc-13.2.0 (GCC) 13.2.0" | ||
CONFIG_CC_VERSION_TEXT="gcc (Debian 13.2.0-7) 13.2.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
drop this change
@@ -810,7 +810,6 @@ CONFIG_ARCH_HAS_GCOV_PROFILE_ALL=y | |||
# end of GCOV-based kernel profiling | |||
|
|||
CONFIG_HAVE_GCC_PLUGINS=y | |||
# CONFIG_GCC_PLUGINS is not set |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
drop this change
I pushed changes to your repo with the commits squashed and renamed. I'm not sure why this closed the PR, but it may have something to do with you working in the master branch not a topic branch. |
some errors occured, don't know where is problem ... systemd/systemd#29268 "vddio" have something with systemd to do ? |
i have bow modules enablement in topic branch and PR is on #8483 |
Hi this is draft for including silead driver and firmware for touchscreen tablets , for review and possible adoption, fetching from fw repo not tested , should be in Libreelec main repo tree cloned, and corresponding changes in package.mk should be adjusted...