config/functions: add C++ compiler and linker flags to meson.conf #3468
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Due to missing cpp_args and cpp_link_args in meson.conf ninja builds of projects with C++ code were performed without CPU optimization flags (-march, -mcpu, -mtune etc). Add these args so C++ code is built with proper flags. Signed-off-by: Matthias Reichl <[email protected]>
HiassofT
force-pushed
the
le10-meson-cpp
branch
from
68cffda to
24e31c0
Compare
InuSasha
reviewed
Apr 29, 2019
| @@ -386,6 +386,8 @@ endian = '$endian' | |||
| root = '$root' | |||
| $(python -c "import os; print('c_args = {}'.format([x for x in os.getenv('CFLAGS').split()]))") | |||
| $(python -c "import os; print('c_link_args = {}'.format([x for x in os.getenv('LDFLAGS').split()]))") | |||
| $(python -c "import os; print('cpp_args = {}'.format([x for x in os.getenv('CXXFLAGS').split()]))") | |||
There was a problem hiding this comment.
mixing cpp and cxx looks wrong.
should it more like 'cpp_args -> CPPFLAGS' and 'cxx_args -> CXXFLAGS' ?
There was a problem hiding this comment.
oh holy...
you are right: meson uses cpp_args for c++. really confusing
https://mesonbuild.com/Builtin-options.html#compiler-options
|
Tested with |
|
This PR results in a nice reduction on Generic ( |
MilhouseVH
approved these changes
May 4, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to missing cpp_args and cpp_link_args in meson.conf ninja builds
of projects with C++ code were performed without CPU optimization
flags (-march, -mcpu, -mtune etc). Add these args so C++ code is
built with proper flags.