Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rpi: switch to zstd squashfs images #3212

Merged
merged 4 commits into from
May 9, 2019

Conversation

antonlacon
Copy link
Contributor

@antonlacon antonlacon commented Jan 5, 2019

For LE10.

Switch generic too? I'm not sure a user will notice but it should save bandwidth/storage on LE's end.

Benchmarks available here: #3209

@MilhouseVH
Copy link
Contributor

Switch generic too?

It probably requires a little more analysis to be sure (ie. file size comparisons etc.), but I suspect we could probably switch all systems to zstd for LE10, kernel support permitting.

@CvH
Copy link
Member

CvH commented Jan 5, 2019

Switch generic too?
if RPi1 can handle it every other Project is fine too, i guess ?

@5schatten
Copy link
Contributor

5schatten commented Jan 6, 2019

I use zstd for Generic since a while and works fine so far.

Btw. what about other ARM platforms like S905?

@CvH
Copy link
Member

CvH commented Jan 6, 2019

Btw. what about other ARM platforms like S905?

AML S905 is faster then RPi3+ so it should (benchmark needed) be okay, requires mainline ofc, ancient 3.14 won't do it.

@antonlacon
Copy link
Contributor Author

Time to look at merging with LE9.2 branched?

@MilhouseVH
Copy link
Contributor

With my own nightly test builds, the SYSTEM image file with zstd is reduced in size as follows:

Before After Change
RPi 140MB 110MB -30MB
RPi2 140MB 110MB -30MB
Generic 246MB 205MB -41MB

Handy! :)

@5schatten
Copy link
Contributor

@antonlacon
I guess you can also add this to Rockchip options. I use it in my community builds and it works fine.

@antonlacon
Copy link
Contributor Author

@Kwiboo fyi on rockchip change. Verified CONFIG_SQUASHFS_ZSTD=y was in configs, but didn't test anything past that.

This also puts all projects on zstd.

@MilhouseVH
Copy link
Contributor

Is this good to go - remove block label and merge?

@antonlacon
Copy link
Contributor Author

As far as I know, it's complete. I've used zstd on rpi since at least October, and the 1MB block size since January.

@MilhouseVH
Copy link
Contributor

Thanks!

@MilhouseVH MilhouseVH merged commit b486229 into LibreELEC:master May 9, 2019
@antonlacon antonlacon deleted the rpi-zstd-img branch June 4, 2019 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants