Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-enable lirc_serial driver #1454

Merged
merged 3 commits into from
Mar 24, 2017
Merged

Conversation

jbollacke
Copy link
Contributor

@jbollacke jbollacke commented Mar 18, 2017

The driver lirc_serial has been renamed to ir_serial in linux v4.10. See torvalds/linux@fa5dc29
But this driver is needed for some IR receivers e.g. Atric IR Receiver to work.

First added in af3d9e7.
Removed in 491b701 (due to migration to linux v4.10).

This PR does:

  • Enable ir_serial as module
  • Add alias named lirc_serial so scripts referencing this module (e.g. autostart.sh) won't break

Do not break old scripts depending on lirc_serial module.
@HiassofT
Copy link
Member

Please add CONFIG_IR_SERIAL_TRANSMITTER=y - LE8 contained CONFIG_LIRC_SERIAL_TRANSMITTER=y as well.

And I'd strongly suggest dropping the modprobe.d file with the alias. People can just change the module name in .config/modules-load.d/*.conf. This is a lot cleaner than adding support for legacy configurations which will then probably linger around forever.

@HiassofT
Copy link
Member

Just had a look at the serial IR driver, by default it uses the rc6-mce map. This means MCE remotes will work out of the box and use in-kernel decoding. Running userspace lircd in parallel to that will result in double keypresses.

So people will have to adjust their configs anyway and remove their lircd.conf if they use an MCE remote (or some other remote supported by LE out of the box).

@jbollacke
Copy link
Contributor Author

As far as I know CONFIG_IR_SERIAL_TRANSMITTER is y by default. See torvalds/linux@fa5dc29#diff-9b924813a0f386da12899ca6acdf420cR404 for reference. So adding it would just make it more verbose.

I agree with dropping the module alias.

@jbollacke jbollacke force-pushed the bugfix/lirc_serial branch from 3625c08 to 6e63ef0 Compare March 19, 2017 18:00
@jbollacke
Copy link
Contributor Author

Will squash later

@lrusak lrusak merged commit cf13c26 into LibreELEC:master Mar 24, 2017
@lrusak
Copy link
Member

lrusak commented Mar 24, 2017

Thanks!

@MilhouseVH
Copy link
Contributor

If you run make oldconfig on the Generic kernel now you are prompted to enable CONFIG_IR_SERIAL_TRANSMITTER or not - the default is "yes", but being verbose and specifying a value means there is no confusion or need to prompt. Will add CONFIG_IR_SERIAL_TRANSMITTER=y in the next kernel bump.

Ray-future pushed a commit to Ray-future/LibreELEC.tv that referenced this pull request Apr 4, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants