-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Re-enable lirc_serial driver #1454
Conversation
Do not break old scripts depending on lirc_serial module.
Please add And I'd strongly suggest dropping the modprobe.d file with the alias. People can just change the module name in .config/modules-load.d/*.conf. This is a lot cleaner than adding support for legacy configurations which will then probably linger around forever. |
Just had a look at the serial IR driver, by default it uses the rc6-mce map. This means MCE remotes will work out of the box and use in-kernel decoding. Running userspace lircd in parallel to that will result in double keypresses. So people will have to adjust their configs anyway and remove their lircd.conf if they use an MCE remote (or some other remote supported by LE out of the box). |
As far as I know I agree with dropping the module alias. |
3625c08
to
6e63ef0
Compare
This reverts commit 3625c08.
Will squash later |
Thanks! |
If you run |
The driver lirc_serial has been renamed to ir_serial in linux v4.10. See torvalds/linux@fa5dc29
But this driver is needed for some IR receivers e.g. Atric IR Receiver to work.
First added in af3d9e7.
Removed in 491b701 (due to migration to linux v4.10).
This PR does:
Add alias named lirc_serial so scripts referencing this module (e.g. autostart.sh) won't break