Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update lirc #1101

Merged
merged 3 commits into from
Jan 2, 2017
Merged

Update lirc #1101

merged 3 commits into from
Jan 2, 2017

Conversation

Kwiboo
Copy link
Member

@Kwiboo Kwiboo commented Dec 27, 2016

This PR updates lirc to 0.9.4c and fixes a build issue when python is not installed on the build host.

This needs more runtime testing before merge.

Dropped patches have been replaced by upstream.

0.9.4a 29/6/16

    Fix syntax errors in systemd unit files (rhbz: 1350750).
    irrecord: Enhance "Don't use devinput" message (#180).
    plugins/uirt2_raw: Reset device to UIR mode on deinit.
    plugins/girs.c: Enable reception after sending.
    lirc.org: Updates and bugfixes
    lircd, liblirc_client: Fix freeaddrinfo handling (#195).
    Don't build commandir unless we have usb.h (#191).
    lirc_options.conf: debug => loglevel (#199).
    lib: use proper linking method to avoid parallel build issue
    tools: make_rel_symlink.py can also use python2
    plugins/devinput: Make the list-devices support available.
    configure.ac: Bugfix (BSD setting reported wrong).

0.9.4b 9/8/2016

    lircd-uinput: A multitude of fixes (#213, #211, #177). Adds new options.
    lirc_client: Fix "Can't redirect irsend output" (#207).
    lirc_client: Fix un-terminated buffer causing irsend crash (#216).
    irrecord: Fix under-sized buffer causing crash (#208).
    systemd: Add hardening options comments to services (#204).
    lircmd: Options, udev examples and manpage update.
    lib: Add missing Makefile.am dep, fixes parallel build failure (#210).
    Remove a single python2 dependency [4e3c97c].
    build: Don't define docdir - autoconf defines docdir (#215).
    build: support runstatedir configure option (#212).
    doc: Manpages and configuration guide fixes.

0.9.4c 22/10/2016

    New curl_poll files adds a new MIT license. Lirc now carries GPL, BSD and MIT licenses.
    Several patches to make lirc work again on macos (#226, #227).
    New tool irtext2udp generates udp plugin data (#197).
    Fix FTBS errors on linux kernel >= 4.8.0 (#232).
    plugins: girs: Add udp/receive support (#201).
    mode2: Fix broken --raw option (#223).
    lirc-make-devinput: Fix that two remotes has the same name (#222).
    lircd: Warn for duplicate remote definitions (#222).
    lircd: Retry temporary unavailable write sockets (#221).
    contrib: Fix usb devices' acl permissions (rhbz #1364744).
    lirc-setup: Fix crasher bugfix (Fedora abort trace).
    contrib: disable udev /dev/uinput rule requiring lirc user.
    plugins: audio_alsa: Fix byte truncating in 16-bit data (#218):
    plugins: irtoy: improve error handling (#220).
    Minor documentation fixes.

@HiassofT
Copy link
Member

I think you can drop lirc-0005-uinput.patch, this should be fixed upstream https://sourceforge.net/p/lirc/tickets/213/

lircd-uinput should now also work fine (https://sourceforge.net/p/lirc/tickets/211/) so I think we're now good to switch to that and drop the deprecated --uinput option of lircd.

@lrusak
Copy link
Member

lrusak commented Dec 28, 2016

We might want this back then, lrusak@cd18f93

@Kwiboo
Copy link
Member Author

Kwiboo commented Dec 28, 2016

@HiassofT @lrusak Thanks!, wasn't sure about the uinput patch to begin with.

I have now dropped lirc-0005-uinput.patch and added a slightly modified version of lrusak/LibreELEC.tv@cd18f93
I had to add --release=_UP to the lircd config or a pressed key would end up repeated indefinitely.

Should eventlircd drop the --release=_UP argument now that lircd generates _UP events?

@lrusak
Copy link
Member

lrusak commented Dec 28, 2016

I'm not sure about the --release=_UP argument. It's probably worth it to do some testing and get it into a @MilhouseVH build

@Kwiboo
Copy link
Member Author

Kwiboo commented Dec 28, 2016

Updated again: 98-eventlircd.rules modified to enable eventlircd for lircd-uinput devices

@Kwiboo
Copy link
Member Author

Kwiboo commented Dec 28, 2016

It is probably best to leave --release=_UP on eventlircd, it does not generate an extra _UP events.

From lircd socket:

# irw /run/lirc/lircd-lirc0
000000004db253ac 00 KEY_UP odroid_amremote
000000004db253ac 00 KEY_UP_UP odroid_amremote
000000004db2837c 00 KEY_RIGHT odroid_amremote
000000004db2837c 00 KEY_RIGHT_UP odroid_amremote
000000004db24bb4 00 KEY_DOWN odroid_amremote
000000004db24bb4 00 KEY_DOWN_UP odroid_amremote
000000004db29966 00 KEY_LEFT odroid_amremote
000000004db29966 00 KEY_LEFT_UP odroid_amremote

From eventlircd socket:

# irw /run/lirc/lircd
67 0 KEY_UP devinput
67 0 KEY_UP_UP devinput
6a 0 KEY_RIGHT devinput
6a 0 KEY_RIGHT_UP devinput
6c 0 KEY_DOWN devinput
6c 0 KEY_DOWN_UP devinput
69 0 KEY_LEFT devinput
69 0 KEY_LEFT_UP devinput

@MilhouseVH
Copy link
Contributor

MilhouseVH commented Dec 28, 2016

Seems to be working on NUC (Skylake, Harmony One with RC6 profile). Will include in build tonight. Please keep an eye out for issues.

Edit: Build I just tested includes:

Updated again: 98-eventlircd.rules modified to enable eventlircd for lircd-uinput devices

@Kwiboo
Copy link
Member Author

Kwiboo commented Dec 28, 2016

@MilhouseVH thanks for including this in your build!

I have no more changes planed as everything seems to be back to "normal" after the 98-eventlircd.rules change.

@CvH CvH added the UPDATE label Dec 29, 2016
@HiassofT
Copy link
Member

HiassofT commented Jan 1, 2017

I've tested Milhouse build 1231 on a RPi3 with GPIO receiver and so far everything seems to be fine!

@lrusak
Copy link
Member

lrusak commented Jan 2, 2017

@MilhouseVH all good?

Copy link
Contributor

@MilhouseVH MilhouseVH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No problems reported so far - seems to be good.

@MilhouseVH MilhouseVH merged commit 56f05ab into LibreELEC:master Jan 2, 2017
@Kwiboo Kwiboo deleted the lirc-python branch January 2, 2017 23:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants