Cloudformation templates to deploy feature branch to crowd-test

[rstorey]

I wish I didn't have to make a special copy of the elasticache template for this, but I couldn't figure out how to pass the list of subnet IDs as a string as required. Any thoughts on that?

I'm also not sure if the parameter "ConcordiaBranch" should actually be "DockerTag" since that's what it is. I'm making the assumption that Jenkins (or something) will build and publish feature branches to our container repository with the docker tag = branch name. Jenkins is doing this already

[coveralls]

Coverage decreased (-0.02%) to 69.456% when pulling d07deb6 on deploy-feature-branch into d8cc4b6 on master.

[acdha]

This generally looks good to me. The one question I had is whether we should be taking the time now to convert the hard-coded names for security groups, VPC IDs, etc. into output references or not. I'm slightly hesitant to do so since that adds more exposure to CloudFormation bugs but it would reduce the number of updates.

[rstorey]

This generally looks good to me. The one question I had is whether we should be taking the time now to convert the hard-coded names for security groups, VPC IDs, etc. into output references or not. I'm slightly hesitant to do so since that adds more exposure to CloudFormation bugs but it would reduce the number of updates.

I was sorta thinking that too. Like, what if we decide we want to push feature branches to crowd-dev or something, what would the changes need to be, what should be parameterized, etc. But, I figured I'd address that if / when we decide to do this sort of thing again in a different VPC.