perf: optimize drop logic and add id to inline child elements

1.Remove delete field operation as invalid 2.Add id to inline child element
Liberty-liu · Sep 20, 2023 · 9579750 · 9579750
1 parent 7f3c51b
commit 9579750
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 6 deletions.
diff --git a/packages/formEditor/components/Layout/ControlInsertionPlugin.js b/packages/formEditor/components/Layout/ControlInsertionPlugin.js
@@ -328,11 +328,11 @@ function ControlInsertionPlugin (ER) {
       if (!isBlock) {
         if (oldEl.context) {
           oldEl.context.delete()
-          utils.deepTraversal(oldEl, (node) => {
-            if (utils.checkIsField(node)) {
-              ER.delField(node)
-            }
-          })
+          // utils.deepTraversal(oldEl, (node) => {
+          //   if (utils.checkIsField(node) && node.type !== 'subform') {
+          //     ER.delField(node)
+          //   }
+          // })
         }
       }
       if (inserRowIndex !== '') {

diff --git a/packages/formEditor/components/Layout/DragGable.jsx b/packages/formEditor/components/Layout/DragGable.jsx
@@ -156,7 +156,8 @@ export default defineComponent({
               TypeComponent = load.findComponent('FormTypes', element.type)
               const params = {
                 data: element,
-                parent: props.data
+                parent: props.data,
+                key: element.id
               }
               if (process.env.NODE_ENV === 'test') {
                 params['data-field-id'] = `${element.id}`