Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Julia 1.7.2 and update dependencies #45

Merged
merged 8 commits into from
Apr 4, 2022

Conversation

jamesmurdza
Copy link
Contributor

@jamesmurdza jamesmurdza commented Mar 31, 2022

I have updated to Julia 1.7.2, updated dependencies, and fixed some small errors related to updating Ipopt.

It appears to work fine now, however I have one issue (#44) which I can’t tell is related to these changes or not.

If it helps for testing, there is also a Docker file here: https://github.com/possibleplanets/DICE.jl-notebooks/blob/master/Dockerfile

@Libbum
Copy link
Owner

Libbum commented Apr 1, 2022

@jamesmurdza, I found the issue in #44, can you click the "Allow edits from maintainers" button so I can push a fix?

here

@jamesmurdza
Copy link
Contributor Author

@Libbum Great!

Oddly I can't (isaacs/github#1681). I can only add you to my fork.

@Libbum
Copy link
Owner

Libbum commented Apr 1, 2022

Oh! Wasn't aware of that limitation sorry.

Give those changes a shot and see if they work for you?

If so we can merge this and I'll release a new version.

@jamesmurdza
Copy link
Contributor Author

Works great on my setup!

@Libbum Libbum merged commit 62b69c6 into Libbum:master Apr 4, 2022
@Libbum Libbum deleted the ipopt-1.0.2 branch April 4, 2022 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants