Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Save/Update/Finish Button hidden by status bar #156

Closed
corayana opened this issue May 9, 2024 · 11 comments · Fixed by #160, #188 or #356
Closed

Save/Update/Finish Button hidden by status bar #156

corayana opened this issue May 9, 2024 · 11 comments · Fixed by #160, #188 or #356
Labels
bug Something isn't working planned

Comments

@corayana
Copy link

corayana commented May 9, 2024

Hi,
I just started using your app and am pretty happy so far.
One issue that bothers me is that the app reaches under the status bar on my phone (Google Pixel 4a). This makes it very difficult to save/update or finish a session. I would bei very happy you could fix this.

Screenshot_20240509-140845

@LiamMorrow
Copy link
Owner

Thanks for the report! It definitely shouldn't be doing that, I'll see what I can do

@LiamMorrow
Copy link
Owner

Would you be able to tell me your android version please?
You can find it by going into your phone's settings, scrolling to "System" then tapping "About Phone"

Thank you!

@corayana
Copy link
Author

Thank you for the quick response. My android version is 13.

@LiamMorrow
Copy link
Owner

Fantastic. I'll have a play with the emulator tonight to see what I can do.

@LiamMorrow
Copy link
Owner

I cannot for the life of me get this bug to show up I'm afraid. I have a workaround, which would just amount to offsetting the top by a static distance. I'll release a new version with this toggle which should help you in the meantime.

@corayana
Copy link
Author

Thank you very much for your efforts! Unfortunately, I have no idea what the problem might be.
Anyway, the workaround works so far, at least for ending a session (but not for creating/editing a new/existing session)

@LiamMorrow
Copy link
Owner

Yeah it's a headscratcher. You say it doesn't work for creating/editing sessions. Could you show me a screenshot of what you mean? It should apply everywhere

@LiamMorrow
Copy link
Owner

Also, do you have developer mode enabled? If so, would you be able to show your WebView implementation? I wonder if it's a browser version issue...

@LiamMorrow
Copy link
Owner

ViewCompat.SetOnApplyWindowInsetsListener(

This is where I perform the calculation to get the insets. It works on all emulators and my phone (asus zenfone 9).

@LiamMorrow LiamMorrow added the help wanted Extra attention is needed label Sep 24, 2024
@spar34vi
Copy link

I'm getting the same issue on Pixel 7 pro (android 15)

@LiamMorrow
Copy link
Owner

I've got a clue! Seems like I can reproduce it when using a non english language (thanks for the translation @spar34vi!) I have a feeling I know exactly what it is now... I think that the inset is resolving to a decimal, and I am formatting it for the css using the region's format (i.e. commas). But CSS is not regionalised, and it REQUIRES periods.

image

A fix for this will be inbound! 🎉 Thanks for all the reports!

@LiamMorrow LiamMorrow added bug Something isn't working planned and removed cant-replicate help wanted Extra attention is needed labels Dec 17, 2024
LiamMorrow added a commit that referenced this issue Dec 17, 2024
In android, there has been an issue where the status bar did not always reserve space for itself.
It was found that this is a localisation issue, and we were creating invalid CSS as decimals were being split by commas.

Fixes: #156
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working planned
Projects
None yet
3 participants