Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: add pyproject.toml and switch to Hatch build system #37

Merged
merged 1 commit into from
Mar 4, 2024
Merged

build: add pyproject.toml and switch to Hatch build system #37

merged 1 commit into from
Mar 4, 2024

Conversation

ariostas
Copy link
Member

I added a pyproject.toml file since it was long overdue. I took this chance to switch from SetupTools to Hatch to keep things simpler. Also, I moved the Python code to the src directory since it is not recommended to keep it at the top level.

mdemi
mdemi reviewed Feb 25, 2024
View reviewed changes
Copy link
Contributor

@mdemi mdemi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we just remove the cytools folder and put the source code under src, i.e. /src/... instead of /src/cytools/... ?

@ariostas
Copy link
Member Author

Should we just remove the cytools folder and put the source code under src, i.e. /src/... instead of /src/cytools/... ?

It should be under src/<name_of_package>/. For example, look at this guide.

@natemacfadden natemacfadden merged commit 08ad772 into main Mar 4, 2024
1 check passed
@ariostas ariostas deleted the add_pyproject.toml branch March 5, 2024 01:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdemi mdemi mdemi left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ariostas @mdemi @natemacfadden