Skip to content

Commit

Permalink
Finish using named issues in pylint
Browse files Browse the repository at this point in the history
  • Loading branch information
Liam-Deacon committed Oct 13, 2020
1 parent 7dfb67c commit cf11f6f
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion online_store/backend/routes/gifts.py
Original file line number Diff line number Diff line change
Expand Up @@ -139,7 +139,7 @@ def remove_gift(gift_id: int) -> Response:
tags:
- gifts
"""
gift = get_giftlist().remove_item(gift_id) # pylint: disable=W0612; noqa
gift = get_giftlist().remove_item(gift_id) # pylint: disable=unused-variable; noqa
# TODO: check that gift belongs to user, stop if not
return jsonify({"msg": "Gift removed from list",
"status": "ok", "code": HTTPStatus.OK}), HTTPStatus.OK
Expand Down
4 changes: 2 additions & 2 deletions online_store/backend/routes/store.py
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ def items():
params = dict(request.args)
fields: Optional[List[str]] = \
str(params.pop('fields', "")).split(',')
_purchased: bool = bool(params.pop('purchased', False)) # pylint: disable=W0612
purchased: bool = bool(params.pop('purchased', False)) # pylint: disable=unused-variable
query = ItemModel.query \
.filter_by(**params) \
.options(load_only(*fields)) # FIXME:
Expand Down Expand Up @@ -252,7 +252,7 @@ def delete_order(order_id: int):
if order.status == int(OrderStatus.PAYMENT_RECEIVED):
order_items = OrderItemModel.query.filter_by(order_id=order_id).all()
for item in order_items:
refund(item) # pylint: disable=W0621
refund(item) # pylint: disable=redefined-outer-name
refund(order)
elif order.status == int(OrderStatus.CREATED):
order.status = int(OrderStatus.VOIDED)
Expand Down

0 comments on commit cf11f6f

Please sign in to comment.