2.2 #80
Merged
2.2 #80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Development
Development
Changed format for user created & joined
…uirement in change for perms requirement
minor fixes
Added censor and fixed requirements
and reformatted also changed ai a tiny bit.
|
@JasonLovesDoggo can you re-review please |
doesn't matter we are still waiting on db migration and changes. |
…els DB reformatted.
and updated reqs
This reverts commit e264d67.
trivia/tags: used enumerate vs +1 lewis: added failsafe. feat: added tag lb
style: fixed to pep8 reformat.
|
Database migrated |
ImmaHarry
approved these changes
Jul 31, 2023
LevaniVashadze
dismissed
JasonLovesDoggo’s stale review
fixed all requested changes
|
|
||
| before_roles.reverse() | ||
| before_roles.pop() | ||
|
|
There was a problem hiding this comment.
messssssssssssssssssssssyyyyyyyyy
There was a problem hiding this comment.
that's true, but as I said I didn't code it and also don't have time to refactor code
There was a problem hiding this comment.
otherwise I would just do a few simple list comprehensions and clean it up, but that all needs time to code and test afterwards
| for before_name in before.permissions: | ||
| before_.append(before_name) | ||
|
|
||
| for after_name in after.permissions: |
There was a problem hiding this comment.
huhhhh all seems very messy and unsimplified
There was a problem hiding this comment.
I didnt write that code, but yeah can be done in a list comprehension
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
needs db migrating don't merge yet