Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Version 10.0+ does not build with GHC 9.0 #655

Closed
lsrcz opened this issue May 7, 2023 · 5 comments
Closed

Version 10.0+ does not build with GHC 9.0 #655

lsrcz opened this issue May 7, 2023 · 5 comments

Comments

@lsrcz
Copy link
Collaborator

lsrcz commented May 7, 2023

The version 10.0+ contains a new example Documentation.SBV.Examples.Puzzles.Orangutans, which uses the OverloadedRecordDot extension.

The extension is nice but it is GHC 9.2+ only..
@LeventErkok
Copy link
Owner

That’s unfortunate indeed. Alas, I don’t try to support all GHC variants, as trying to do so is an endless task.

if this is a problem for you, I’d recommend getting a local copy and modifying it to either remove the example completely or rewrite it to avoid the overloaded record dot, and use that local version.

@lsrcz
Copy link
Collaborator Author

lsrcz commented May 7, 2023

Thanks for the explanation and that makes sense.

However, it could be helpful to also update the base dependency version to represent this decision to avoid confusion.

@LeventErkok
Copy link
Owner

That’s a good point. Do you mind sending a PR that does that? I’ll be happy to merge!

@LeventErkok LeventErkok reopened this May 7, 2023
@LeventErkok
Copy link
Owner

Waiting for PR to fix the dependency. Thanks.

@lsrcz lsrcz mentioned this issue May 8, 2023
Merged
@LeventErkok
Copy link
Owner

PR merged.

RyanGlScott added a commit to GaloisInc/cryptol that referenced this issue Jul 12, 2023
@RyanGlScott
CI: Prefer Use 9.2.8 (not 8.10.7) for building Docker images
a21f274 
There are two motivations for doing so:

* `sbv-10.0` and later no longer build against GHC 8.10 (see
  LeventErkok/sbv#655), but we want to use a new `sbv`
  version to come to a resolution to #1548. As such, we need a newer GHC.
* `ghcup` now recommends GHC 9.2.8 for most usage, so it's time we switched
  anyway.
@RyanGlScott RyanGlScott mentioned this issue Jul 12, 2023
Merged
RyanGlScott added a commit to GaloisInc/cryptol that referenced this issue Jul 12, 2023
@RyanGlScott
CI: Prefer Use 9.2.8 (not 8.10.7) for building Docker images
6ee853c 
There are two motivations for doing so:

* `sbv-10.0` and later no longer build against GHC 8.10 (see
  LeventErkok/sbv#655), but we want to use a new `sbv`
  version to come to a resolution to #1548. As such, we need a newer GHC.
* `ghcup` now recommends GHC 9.2.8 for most usage, so it's time we switched
  anyway.
RyanGlScott added a commit to GaloisInc/cryptol that referenced this issue Jul 12, 2023
@RyanGlScott
CI: Prefer Use 9.2.8 (not 8.10.7) for building Docker images
77a52e3 
There are two motivations for doing so:

* `sbv-10.0` and later no longer build against GHC 8.10 (see
  LeventErkok/sbv#655), but we want to use a new `sbv`
  version to come to a resolution to #1548. As such, we need a newer GHC.
* `ghcup` now recommends GHC 9.2.8 for most usage, so it's time we switched
  anyway.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@LeventErkok @lsrcz