Skip to content
This repository has been archived by the owner on Dec 1, 2024. It is now read-only.

Simplify appveyor #383

Merged
merged 2 commits into from
Aug 31, 2017
Merged

Simplify appveyor #383

merged 2 commits into from
Aug 31, 2017

Conversation

vweevers
Copy link
Member

Use the standard build process instead of prebuild. See #381 (comment).

Now it doesn't have to download Node.js headers. Also won't publish an artifact (a prebuild per commit) but no one was using that anyway.

@vweevers vweevers requested a review from ralphtheninja August 29, 2017 05:37
@vweevers
Copy link
Member Author

Should do the same for Level/rocksdb.

@vweevers
Copy link
Member Author

Also the random failures of prebuild still need to be addressed, might be a problem when we want to release.

@vweevers
Copy link
Member Author

@vweevers
Copy link
Member Author

But.. now node 5 is failing for a different reason: https://ci.appveyor.com/project/Level/leveldown/build/120/job/6246waj9g906btin

@vweevers
Copy link
Member Author

I reckon that can be fixed with a npm -g i npm@latest but then 0.12 will fail 😄

@vweevers
Copy link
Member Author

Yeah, node 5 fails because of nodejs/node-gyp#972, a golden oldie I forgot about. See also dat-ecosystem-archive/rabin#23.

@vweevers
Copy link
Member Author

@ralphtheninja WDYT about:

Also the random failures of prebuild still need to be addressed, might be a problem when we want to release.

@ralphtheninja
Copy link
Member

@ralphtheninja WDYT about:

Also the random failures of prebuild still need to be addressed, might be a problem when we want to release.

Ah yes. Do we have any more information on what's going on? Happens randomly on all node versions, or just one?

@vweevers
Copy link
Member Author

All node versions. No idea why as of yet.

@ralphtheninja
Copy link
Member

A bit annoying that the build just seems to stop and no more information is given. Generic problem, or a problem related to prebuild? I hoping the former :)

@vweevers
Copy link
Member Author

Maybe we can check if any other projects with prebuild have the same problem?

I'll have some time in the weekend to investigate.

@ralphtheninja
Copy link
Member

@vweevers Merging this as it's unrelated to the random problems

@ralphtheninja ralphtheninja merged commit 3a7cd1f into master Aug 31, 2017
@ralphtheninja ralphtheninja deleted the simplify-appveyor branch August 31, 2017 01:20
@ralphtheninja
Copy link
Member

ralphtheninja commented Aug 31, 2017

Also the random failures of prebuild still need to be addressed, might be a problem when we want to release.

Worst case scenario, we can always restart builds to make prebuilts for failing node versions as a workaround for now. So it's not super urgent to fix, but still important.

@ralphtheninja
Copy link
Member

@vweevers On problems related to building for 0.12 and 5 that you mentioned above. We could consider dropping support for both 0.12 and 5 and release a new major.

@MeirionHughes
Copy link
Member

0.12 is end-of-life. 4 (5) will be end-of-life next April - https://github.com/nodejs/LTS

@vweevers
Copy link
Member Author

I'm happy with the solution (3bcb790). We can keep node 5 until end of life.

@vweevers
Copy link
Member Author

I can't replicate the failures, and anyway, doesn't seem to be a problem for us anymore.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants