-
-
Notifications
You must be signed in to change notification settings - Fork 176
Conversation
Should do the same for |
Also the random failures of prebuild still need to be addressed, might be a problem when we want to release. |
rocksdb has the same problem: https://ci.appveyor.com/project/Level/rocksdb/build/job/2b2aabect7vh7n52 |
But.. now node 5 is failing for a different reason: https://ci.appveyor.com/project/Level/leveldown/build/120/job/6246waj9g906btin |
I reckon that can be fixed with a |
Yeah, node 5 fails because of nodejs/node-gyp#972, a golden oldie I forgot about. See also dat-ecosystem-archive/rabin#23. |
@ralphtheninja WDYT about:
|
Ah yes. Do we have any more information on what's going on? Happens randomly on all node versions, or just one? |
All node versions. No idea why as of yet. |
A bit annoying that the build just seems to stop and no more information is given. Generic problem, or a problem related to prebuild? I hoping the former :) |
Maybe we can check if any other projects with prebuild have the same problem? I'll have some time in the weekend to investigate. |
@vweevers Merging this as it's unrelated to the random problems |
Worst case scenario, we can always restart builds to make prebuilts for failing node versions as a workaround for now. So it's not super urgent to fix, but still important. |
@vweevers On problems related to building for 0.12 and 5 that you mentioned above. We could consider dropping support for both 0.12 and 5 and release a new major. |
0.12 is end-of-life. 4 (5) will be end-of-life next April - https://github.com/nodejs/LTS |
I'm happy with the solution (3bcb790). We can keep node 5 until end of life. |
I can't replicate the failures, and anyway, doesn't seem to be a problem for us anymore. |
Use the standard build process instead of prebuild. See #381 (comment).
Now it doesn't have to download Node.js headers. Also won't publish an artifact (a prebuild per commit) but no one was using that anyway.