Issue 66 & 65 #67
Merged
Issue 66 & 65 #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
#66) * Do not attempt to calculate instances for glyphs flagged wtih "skip" in any of the sources. * Keep the skippedGlyph lib entry.
+ Respect the glyphnames listed in public.skipExportGlyphs when making UFO. + Add a method startLog to be called when we want to see the log after starting without debug. + self.loadFonts() added to generateUFOs(), makeInstance, makeOneInstance, makeFontProportions, makeOneGlyph, makeOneInfo, makeOneKerning. Because it is not always clear whether the fonts were indeed loaded.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
public.skipExportGlyphswhen making UFO. To be clear: glyphNames in public.skipExportGlyphs will not be generated. (Respect public.skipExportGlyphs settings while calculating instances. #66)generateUFOs(), makeInstance(), makeOneInstance(), makeFontProportions(), makeOneGlyph(), makeOneInfo(), makeOneKerning(). Because it is not always clear whether the fonts were indeed loaded. (add loadFonts to the makeOne* methods? #65)startLog()to be called when we want to see the log after starting without debug.