Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] Additional natural Blocks #54

Open
Pingger opened this issue May 1, 2020 · 3 comments
Open

[Enhancement] Additional natural Blocks #54

Pingger opened this issue May 1, 2020 · 3 comments
Labels
enhancement New feature or request

Comments

@Pingger
Copy link

Pingger commented May 1, 2020

Hi,

I found some blocks, that should be added to the NATURAL block group:

minecraft:dragon_egg
minecraft:furnace
minecraft:hopper
minecraft:anvil
tombstone:grave_simple
natura:overworld_berrybush_maloberry
natura:overworld_berrybush_blackberry
natura:overworld_berrybush_blueberry
natura:overworld_berrybush_raspberry
natura:nether_berrybush_blightberry
natura:nether_berrybush_duskberry
natura:nether_berrybush_skyberry
natura:nether_berrybush_stingberry
twilightforest:boss_spawner
twilightforest:tower_device
biomesoplenty:plant_0
biomesoplenty:plant_1

Why?:
minecraft:dragon_egg -> won't fall if block below is removed, but can be teleported, causing it to loose tracking status
minecraft:furnace -> spawn in villages, can't smelt
minecraft:hopper -> spawn in some dungeons of some mods, can't tranfer items
minecraft:anvil -> spawn in some mod constructions, won't take damage?!
tombstone:grave_simple -> can't be picked up
natura:overworld_berrybush_maloberry -> won't grow
natura:overworld_berrybush_blackberry -> won't grow
natura:overworld_berrybush_blueberry -> won't grow
natura:overworld_berrybush_raspberry -> won't grow
natura:nether_berrybush_blightberry -> won't grow
natura:nether_berrybush_duskberry -> won't grow
natura:nether_berrybush_skyberry -> won't grow
natura:nether_berrybush_stingberry -> won't grow
twilightforest:boss_spawner -> won't spawn
twilightforest:tower_device -> won't open doors, can even break door permanently!
biomesoplenty:plant_0 -> won't grow (BerryBush from BoP)
biomesoplenty:plant_1 -> won't grow ...

Greetings

@Pingger Pingger added the question Further information is requested label May 1, 2020
LeonPhilips pushed a commit that referenced this issue May 1, 2020
@LeonPhilips
Copy link
Owner

I'll have to look into adding defaults for other mods, since Tiquality will give a warning if it was unable to find a block. (Someone might not have natura or biomes o plenty installed, and will receive a warning)

@LeonPhilips LeonPhilips added enhancement New feature or request and removed question Further information is requested labels May 1, 2020
@LeonPhilips LeonPhilips changed the title [Question/Discussion] Additional natural Blocks [Enhancement] Additional natural Blocks May 1, 2020
@LeonPhilips
Copy link
Owner

Almost forgot to add: Thank you for your input! Appreciated!

@Pingger
Copy link
Author

Pingger commented May 1, 2020

Maybe check per mod if it is installed and only issue a single warning summarising the mods, that couldn't be found?
Or only check the existence of the mods on initial config generation and add the defaults for all mods that were found? Issue with this: Adding more mods does not update the defaults
Check each launch for the existence for the mods and add the defaults? Issue: manually removing not possible

Best Idea: Add a config value for rechecking for mods? If it is set, unset it and check for mods defaults and add the to the config.

Also added the thaumcraft spawners and doors to the blocks to add, since those also don't work properly when not claimed. (e.g. the twilightforest:boss_spawner)

Greetings

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants