Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Component only changes to another image if both the img and key props change #19

Open
LeoNero opened this issue Mar 8, 2019 · 0 comments
Open

Component only changes to another image if both the img and key props change #19

LeoNero opened this issue Mar 8, 2019 · 0 comments

Comments

@LeoNero
Copy link
Owner

LeoNero commented Mar 8, 2019

Created because of #18
MatrixFrog added a commit to MatrixFrog/react-img-zoom that referenced this issue Oct 7, 2021
@MatrixFrog
Attempted fix for issue LeoNero#19
5ba62cd 
Read props at render time, instead of in the constructor. That way if
props change we're always reading the latest values.
MatrixFrog added a commit to MatrixFrog/react-img-zoom that referenced this issue Oct 7, 2021
@MatrixFrog
fix: fix issue LeoNero#19 by reading props in render() instead of ctor.
9d2d627 
Read props at render time, instead of in the constructor. That way if
props change we're always reading the latest values.
MatrixFrog added a commit to MatrixFrog/react-img-zoom that referenced this issue Oct 7, 2021
@MatrixFrog
fix: fix issue LeoNero#19
cc430fc 
Read props at render time, instead of in the constructor. That way if
props change we're always reading the latest values.
MatrixFrog added a commit to MatrixFrog/react-img-zoom that referenced this issue Oct 7, 2021
@MatrixFrog
fix: fix issue LeoNero#19
463b134 
Read props at render time, instead of in the constructor. That way if
props change we're always reading the latest values.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@LeoNero