Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there,
I noticed while trying to use WebDeck on a device in a separate VLAN (192.168.20.x), it could not connect as the
check_local_network
function explicitly only allows remote IPs from the the local network that WebDeck is located on. (192.168.1.x)I modified
check_local_network
such that it checks if the remote IP matches any networks in theallowed_networks
array located in the config JSON. It is an optional config array (left it empty inconfig_default.json
), but if it exists, the check function will see if the remote IP matches any of the allowed network entries in the array before returning a 403 on requests.This allowed me to access WebDeck from my device in the VLAN mentioned above, once I added the VLAN network to the
allowed_networks
array. Example of the array's usage: