-
-
Notifications
You must be signed in to change notification settings - Fork 889
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change default image_mode to proxy, remove deprecated option #5176
Conversation
6d3fc73
to
7f294a8
Compare
7f294a8
to
75a5c3e
Compare
656f35a
to
8549972
Compare
I'd also be fine with removing the We should probably leave as draft until we make sure lemmy.ml doesn't have any issues with it, as well as any federation problems. |
#4874 seems like one of the things that probably should be addressed before proxying becomes the default |
ada012e
to
793de63
Compare
793de63
to
2b2995f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This has been running stable enough on lemmy.ml for a while now, that I think we can probably merge (after confllicts are fixed).
Up to you whether you want to completely remove the StoreLinkPreviews option here, or do that in a separate PR.
Proxying actually works worse than storing previews locally, for example #5307 (which is why the |
* Change default image_mode to proxy, remove deprecated option * fix api test
I would also consider deprecating/removing the option
StoreLinkPreviews
as proxying can achieve the same purpose much more efficiently.Besides we should enable image proxying on lemmy.ml to ensure that it works well.