Only allow http(s) scheme for urls (ref #3505) #3508
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SleeplessOne1917
approved these changes
Jul 6, 2023
With this change only http(s) schemes are allowed for post.url field. This is checked for incoming api and federation requests. Existing posts in database which are sent to clients are not checked. Neither does it check urls in markdown.
Nutomic
force-pushed
the
filter-url-schema
branch
from
be285c8 to
eaf0fbf
Compare
dessalines
reviewed
Jul 6, 2023
| @@ -302,12 +302,22 @@ pub fn check_site_visibility_valid( | |||
| Ok(()) | |||
| } | |||
|
|
|||
| pub fn check_url_scheme(url: &Option<Url>) -> LemmyResult<()> { | |||
| if let Some(url) = url { | |||
| if url.scheme() != "http" && url.scheme() != "https" { | |||
There was a problem hiding this comment.
["https", "http"].iter().any(|s| s == &url.scheme())
There was a problem hiding this comment.
This is too confusing for such a simple check.
4 tasks
dessalines
approved these changes
Jul 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this change only http(s) schemes are allowed for post.url field. This is checked for incoming api and federation requests. Existing posts in database which are sent to clients are not checked. Neither does it check urls in markdown.