Cache federation blocklist #3486
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nutomic
added a commit
that referenced
this pull request
Jul 5, 2023
dessalines
approved these changes
Jul 5, 2023
| /// multiple times. This causes a huge number of database reads if we hit the db directly. So we | ||
| /// cache these values for a short time, which will already make a huge difference and ensures that | ||
| /// changes take effect quickly. | ||
| const BLOCKLIST_CACHE_DURATION: Duration = Duration::from_secs(60); |
There was a problem hiding this comment.
I can def live with this short of a cache.
Closed
Nutomic
added a commit
that referenced
this pull request
Jul 13, 2023
* Check for dead federated instances (fixes #2221) * move to apub crate, use timestamp * make it compile * clippy * use moka to cache blocklists, dead instances, restore orig scheduled tasks * remove leftover last_alive var * error handling * wip * fix alive check for instances without nodeinfo, add coalesce * clippy * move federation blocklist cache to #3486 * unused deps
Nutomic
added a commit
to cetra3/lemmy
that referenced
this pull request
Jul 19, 2023
* Check for dead federated instances (fixes LemmyNet#2221) * move to apub crate, use timestamp * make it compile * clippy * use moka to cache blocklists, dead instances, restore orig scheduled tasks * remove leftover last_alive var * error handling * wip * fix alive check for instances without nodeinfo, add coalesce * clippy * move federation blocklist cache to LemmyNet#3486 * unused deps
Nutomic
added a commit
that referenced
this pull request
Jul 21, 2023
* Check for dead federated instances (fixes #2221) * move to apub crate, use timestamp * make it compile * clippy * use moka to cache blocklists, dead instances, restore orig scheduled tasks * remove leftover last_alive var * error handling * wip * fix alive check for instances without nodeinfo, add coalesce * clippy * move federation blocklist cache to #3486 * unused deps
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All incoming and outgoing federation actions read the blocklist/allowlist and slur filters multiple times. This causes a huge number of database reads if we hit the db directly. So we cache these values for a short time, which will already make a huge difference and ensures that changes take effect quickly.
From @phiresky: