Adding TOTP / 2FA to lemmy #2741
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nutomic
reviewed
Feb 18, 2023
|
I think this feature will require some specific documentation so client devs know how to implement it. |
|
I can do that, just let me know where. |
|
Best write it in the joinlemmy docs. |
|
I'll do that In the lemmy js client API docs. |
|
I had to use |
Nutomic
requested changes
Feb 25, 2023
crates/utils/src/utils/validation.rs
Outdated
| Some(site_name.to_string()), | ||
| username.to_string(), | ||
| ) | ||
| .map_err(|_| LemmyError::from_message("Couldnt generate TOTP")) |
|
Can you also link the docs you are writing for this so I can have a look? |
|
These get bundled into the client docs: https://github.com/LemmyNet/lemmy-js-client/pull/106/files |
|
This should be ready to go now. |
Nutomic
approved these changes
Mar 2, 2023
This was referenced Jun 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The front end for this is almost done.