-
Notifications
You must be signed in to change notification settings - Fork 338
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix post view crosspost display #1425
Conversation
Where is the value of |
@@ -591,7 +591,10 @@ export class PostListing extends Component<PostListingProps, PostListingState> { | |||
} | |||
|
|||
duplicatesLine() { | |||
const dupes = this.props.crossPosts; | |||
const dupes = this.props.crossPosts?.filter( | |||
pv => pv.community.id !== this.postView.community.id |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Using the pv.post.id
is better here, because a single post could have some historical cross-posts. For example, a github project might be posted multiple times over the course of a few years.
@jsit You're correct, this is also a bug in the back end. I'll get a PR out for that shortly. |
Thanks. Maybe best then, @alectrocute, to add a |
Actually you can probably close this one, I'll have a back-end fix for it shortly anyway. |
mmk ya I finished the back-end PR, we can close. |
Hi Lemdevs!
Currently, the crosspost UI is displaying for all posts even if the post isn't crossposted.
I propose we:
PostView
.Resolves #1394.
Thanks all!