Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve login form #953

Merged
merged 11 commits into from
Jul 8, 2023
Merged

Improve login form #953

merged 11 commits into from
Jul 8, 2023

Conversation

MV-GH
Copy link
Collaborator

@MV-GH MV-GH commented Jul 2, 2023

  • Filters instance list
  • Can type in dropdown if options are showing
  • FieldTexts dont grow with text
  • LoadingIndicator fits the button now

Could not solve the KeepassDX autofill issue, according to docs it looks for username and password combo. We have that so the issue must be with KeePassDX since other password managers do work fine.

Fixes #879

studio64_VKvFOdxju9.mp4

@MV-GH
Copy link
Collaborator Author

MV-GH commented Jul 3, 2023

Honestly, did not fully understand nor experience what you wrote regarding the filter thing. But i did make a small change that made it better.

Copy link
Member

@dessalines dessalines left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, I'll let @twizmwazin test it too.

@twizmwazin twizmwazin enabled auto-merge (squash) July 8, 2023 00:27
@twizmwazin twizmwazin merged commit 2d5b576 into LemmyNet:main Jul 8, 2023
@MV-GH MV-GH deleted the feat/879 branch September 20, 2023 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve login form
3 participants