Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add local crash tracking and viewing #945

Merged
merged 5 commits into from
Jul 12, 2023
Merged

Conversation

camporter
Copy link
Contributor

@camporter camporter commented Jul 2, 2023

Uses https://github.com/FunkyMuse/Crashy to save and access previous app crashes.

Screen_recording_20230711_000849.mp4

@camporter
Copy link
Contributor Author

I've left this in draft just to gauge the feelings behind local crash reporting. There was an issue discussing this and other solutions, but I can't seem to find it now.

@MV-GH
Copy link
Collaborator

MV-GH commented Jul 7, 2023

I think you mean #681. This pretty great but I'm guessing if you crash at startup this won't be useable?

@camporter
Copy link
Contributor Author

Right. Start up crashes should still be recorded depending on how bad they are, but won't be accessible to a user without doing something to avoid the crash.

This avoids transmitting crashes somewhere that users might not like or trust, and is at least better than no way (besides system crash reporting) to get crashes to report.

Copy link
Member

@dessalines dessalines left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like a good idea to have this, thanks. Fix conflicts then we can test.

@camporter
Copy link
Contributor Author

👍 rebased

@camporter camporter marked this pull request as ready for review July 11, 2023 05:13
@@ -102,6 +102,10 @@
<string name="community_sortBy">Sort by</string>
<string name="community_subscribe">Subscribe</string>
<string name="community_users_month">%1$s users / month</string>
<string name="crashes">Crashes</string>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe "Crash logs", "All crash logs deleted", "Copy crash log" and "Delete all crash logs"?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes that's much easier to read, changed 👍

Copy link
Member

@dessalines dessalines left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested this, and it seems to work. Thx!

@MV-GH MV-GH enabled auto-merge (squash) July 12, 2023 16:01
@MV-GH MV-GH merged commit 7072258 into LemmyNet:main Jul 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants