Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show the users' federated name in drawer. #937

Merged
merged 8 commits into from
Jul 3, 2023

Conversation

camporter
Copy link
Contributor

This lets users know which instance they are on more easily.

Also change the 'Switch to' name/server format to match the federated name format using @.

federated_name_in_drawer

@MV-GH
Copy link
Collaborator

MV-GH commented Jul 1, 2023

What happens if the name is way too long? Does it completely clip it out? If so you should probably change the text clipping to do the ellipsis thing.

@camporter
Copy link
Contributor Author

The federated name was previously given one line and clip. Gave it two and ellipsis and it seems like that should be plenty 🙂

The existing PersonName behavior I've left alone.

Both were able to knock the expandable arrow out of the row, so set weights.

@MV-GH
Copy link
Collaborator

MV-GH commented Jul 2, 2023

Greek string file should be updated now too

Copy link
Member

@dessalines dessalines left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@dessalines dessalines merged commit e51ab9f into LemmyNet:main Jul 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants