Fix edit comment view text is being empty #897
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yeah I must have forgotten or lost in merge conflict ig. One suggestion: the commentView to be edited is passed to the composable / activity. That could be used directly instead of reading from the viewmodel. |
|
Yeah that worked too. Kinda do feel like that Viewmodel isnt even needed there |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the edit comment view being empty
It was composed first before the initialize was called which sets the commentView. Causing it to set the remember with empty text. I changed the remember to change when commentView changes. Not sure if it is normal that it compose before initialize fires. @nahwneeth ?
Fixes #895
studio64_WiCPugC9g7.mp4