Add swiping between posts in PostActivity #872

kensand · 2023-06-24T18:35:35Z

This was a feature that I absolutely could not live without in BaconReader. This lets you swipe left and right when in a post to get to the next or previous one. Let me know your thoughts.

Thanks!

MV-GH · 2023-06-24T19:20:13Z

Does this conflict with #785 ?

kensand · 2023-06-24T19:37:37Z

Huh - To be honest, I didn't even notice that feature. I suppose this renders that non-functional - I'm using my build right now on my phone and it does not go back to the HomeActivity when swiping right.

I guess my question then is how to best bring the two features together? Personally, I can live without #785 in favor of this.

MV-GH · 2023-06-24T19:45:45Z

The codeowners are gonna have to decide that but most likely you will have to set an option somewhere to decide between yours, the previous and none.

kensand · 2023-06-24T19:47:45Z

Yeah, that's probably the best solution - I'll get started on adding that as an option in the meantime.

twizmwazin

Let's make this a setting, "Allow swiping between posts" or something like that. Disabled by default. When disabled, the current behaviour is maintained where swiping right on the post view will return you to the home/community view. If enabled, then you must use back or the back arrow in the top left to navigate back, and swiping left/right switches between posts.

kensand · 2023-06-25T00:45:50Z

Cleaned everything up a bit and got it functioning as requested @twizmwazin - should be all set for your review 🤞

Thanks for taking the time!

app/src/main/java/com/jerboa/ui/components/common/SwipeBetweenPosts.kt

app/src/main/java/com/jerboa/ui/components/home/HomeViewModel.kt

app/src/main/res/values/strings.xml

nahwneeth · 2023-06-26T05:32:30Z

What behaviour should be expected when the post is opened via deep link? The post might not be in the list of posts loaded by HomeViewModel.

kensand · 2023-06-26T11:06:35Z

@nahwneeth If the current post is not in the post list, then swiping will simply have no effect; there is no forward/backward on a deep link, right?

MV-GH · 2023-07-07T16:42:47Z

@twizmwazin imo there should also be an option to disable both behaviours, i frequent /c/jerboa and #979. There are users who do not want either. Simple turning it into a Enum with a additional None would suffice and it should default to none.

kensand · 2023-07-09T16:34:31Z

@twizmwazin imo there should also be an option to disable both behaviours, i frequent /c/jerboa and #979. There are users who do not want either. Simple turning it into a Enum with a additional None would suffice and it should default to none.

FWIW, I agree, and am happy to implement it that way 👍

# Conflicts: # app/src/main/java/com/jerboa/MainActivity.kt # app/src/main/java/com/jerboa/db/AppDB.kt # app/src/main/java/com/jerboa/model/CommunityViewModel.kt # app/src/main/java/com/jerboa/model/HomeViewModel.kt # app/src/main/java/com/jerboa/ui/components/post/PostActivity.kt

# Conflicts: # app/schemas/com.jerboa.db.AppDB/18.json # app/src/main/java/com/jerboa/db/AppDB.kt # app/src/main/java/com/jerboa/db/Migrations.kt

dessalines · 2023-07-10T19:32:43Z

app/src/main/java/com/jerboa/model/CommunityViewModel.kt

+    var communityName: String? by mutableStateOf(null)
+
+    var fetchingMore by mutableStateOf(false)
+        private set


You'll need to re-merge from main, because all these should be removed now.

MV-GH

Thanks for coming back to this. I ll take a deeper look some time later

app/build.gradle.kts

app/schemas/com.jerboa.db.AppDB/18.json

app/src/main/java/com/jerboa/db/AppDB.kt

app/src/main/java/com/jerboa/model/CommunityViewModel.kt

app/src/main/java/com/jerboa/ui/components/common/PostStream.kt

app/src/main/java/com/jerboa/ui/components/common/Route.kt

build.gradle.kts

app/src/main/java/com/jerboa/model/CommunityViewModel.kt

app/src/main/java/com/jerboa/model/HomeViewModel.kt

MV-GH · 2023-09-18T01:10:06Z

app/src/main/java/com/jerboa/ui/components/inbox/InboxActivity.kt

-                        } else {
-                            appState.toPost(id = crv.post.id)
-                        }
+                        // TODO navigate to comment (using appState.toComment()) once the route is supported


What's blocking this?

In my testing, navigating to the Comment route caused a crash, presumably because it is not supported by any existing composable 🤷

app/src/main/java/com/jerboa/ui/components/post/PostActivity.kt

kensand · 2023-09-18T02:01:48Z

I found a bug where, after having already gone into the CommunityActivity once, going back to the HomeActivity and then back to a different CommunityActivity, then trying to use swiping between posts no longer works, which appears to be due to the CommunityViewModel that is passed into the PostSwipeWrapper not being updated/recreated with the new communityId (and therefor not containing the current PostId). I'll need to have a further look at that.

MV-GH

There also some warnings that need to fixed. I still need to take a deeper look at this

MV-GH · 2023-09-18T12:04:25Z

app/src/main/java/com/jerboa/MainActivity.kt

-                            showVotingArrowsInListView = appSettings.showVotingArrowsInListView,
-                            showParentCommentNavigationButtons = appSettings.showParentCommentNavigationButtons,
-                            navigateParentCommentsWithVolumeButtons = appSettings.navigateParentCommentsWithVolumeButtons,
-                            siteViewModel = siteViewModel,


the toComment crashes because you removed this composable.

This is the one that makes it possible

dessalines · 2023-09-19T01:00:52Z

There are so many changes here that you might be better off starting from main and either copy-pasting or cherry-picking.

dessalines · 2023-09-26T01:14:39Z

Stale PR. I can re-open if necessary.

kensand and others added 2 commits June 24, 2023 14:32

Add swiping between posts in PostActivity

0aa46c1

Merge branch 'dessalines:main' into main

97916b1

kensand requested review from dessalines and twizmwazin as code owners June 24, 2023 18:35

Fix formatting

d62fff9

twizmwazin reviewed Jun 24, 2023

View reviewed changes

kensand and others added 3 commits June 24, 2023 20:24

Merge branch 'main' into main

e30c000

Refactor SwipeBetweenPosts, add setting

074df46

Fix formatting

c5afa8f

Merge branch 'main' into main

ca6aea8

twizmwazin suggested changes Jun 25, 2023

View reviewed changes

kensand and others added 6 commits June 25, 2023 09:39

Merge branch 'dessalines:main' into main

46a0875

Localize strings and cleanup styling in SwipeBetweenPosts

c3bd3dd

Rename setting to 'Allow swipe between posts'

8fc900e

Fix formatting

4c016d7

Revert extraneous formatting changes to HomeViewModel.kt

23f6adf

Merge branch 'main' into main

dc6abcf

Merge branch 'main' into main

68e9584

kensand and others added 5 commits June 26, 2023 17:03

Merge branch 'main' into main

84d0121

Merge branch 'main' into main

a5ebaad

Fix typos from merge

2f5f5ce

Fix issues introduced after merging

0362eec

Fix formatting

6dc3bcf

kensand and others added 4 commits June 30, 2023 17:37

Merge branch 'main' into main

bcce67e

Use navigation

fcc4fff

Merge branch 'main' into main

d92252d

Rename Allow swiping between posts

a01eaff

kensand requested a review from twizmwazin July 1, 2023 14:32

kensand added 2 commits July 1, 2023 18:52

Merge branch 'main' into main

484504c

Merge branch 'main' into main

f7e6c52

kensand added 3 commits July 9, 2023 12:56

Fix formatting

1843ca8

Merge branch 'main' of github.com:dessalines/jerboa

b6495ce

# Conflicts: # app/schemas/com.jerboa.db.AppDB/18.json # app/src/main/java/com/jerboa/db/AppDB.kt # app/src/main/java/com/jerboa/db/Migrations.kt

dessalines requested changes Jul 10, 2023

View reviewed changes

Merge remote-tracking branch 'upstream/main'

14a3919

kensand requested a review from MV-GH as a code owner September 17, 2023 12:21

kensand added 2 commits September 17, 2023 08:23

Merge branch 'upstream-main'

4588367

Appease linter

5474990

MV-GH requested changes Sep 17, 2023

View reviewed changes

kensand added 4 commits September 17, 2023 20:43

Revert outdated changes against upstream

860ec9c

Revert Schema 18

91b8098

Use POST_BUFFER_COUNT in HomeViewModel and add documentation

79776c0

Remove fetchingMore mutableState in CommunityViewModel

5a29245

MV-GH requested changes Sep 18, 2023

View reviewed changes

kensand added 2 commits September 17, 2023 21:54

Revert formatting

d02cebc

Use isLoading helper function underneath isFetchingMore

15f383e

MV-GH requested changes Sep 18, 2023

View reviewed changes

dessalines closed this Sep 26, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add swiping between posts in PostActivity #872

Add swiping between posts in PostActivity #872

kensand commented Jun 24, 2023

MV-GH commented Jun 24, 2023

kensand commented Jun 24, 2023

MV-GH commented Jun 24, 2023

kensand commented Jun 24, 2023

twizmwazin left a comment

kensand commented Jun 25, 2023

nahwneeth commented Jun 26, 2023

kensand commented Jun 26, 2023

MV-GH commented Jul 7, 2023

kensand commented Jul 9, 2023

dessalines Jul 10, 2023

MV-GH left a comment

MV-GH Sep 18, 2023

kensand Sep 18, 2023

kensand commented Sep 18, 2023 •

edited

Loading

MV-GH left a comment

MV-GH Sep 18, 2023

dessalines commented Sep 19, 2023

dessalines commented Sep 26, 2023

Add swiping between posts in PostActivity #872

Add swiping between posts in PostActivity #872

Conversation

kensand commented Jun 24, 2023

MV-GH commented Jun 24, 2023

kensand commented Jun 24, 2023

MV-GH commented Jun 24, 2023

kensand commented Jun 24, 2023

twizmwazin left a comment

Choose a reason for hiding this comment

kensand commented Jun 25, 2023

nahwneeth commented Jun 26, 2023

kensand commented Jun 26, 2023

MV-GH commented Jul 7, 2023

kensand commented Jul 9, 2023

dessalines Jul 10, 2023

Choose a reason for hiding this comment

MV-GH left a comment

Choose a reason for hiding this comment

MV-GH Sep 18, 2023

Choose a reason for hiding this comment

kensand Sep 18, 2023

Choose a reason for hiding this comment

kensand commented Sep 18, 2023 • edited Loading

MV-GH left a comment

Choose a reason for hiding this comment

MV-GH Sep 18, 2023

Choose a reason for hiding this comment

dessalines commented Sep 19, 2023

dessalines commented Sep 26, 2023

kensand commented Sep 18, 2023 •

edited

Loading