Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bottom nav bar and screen transitions #855

Merged
merged 6 commits into from
Jun 24, 2023

Conversation

nahwneeth
Copy link
Contributor

@nahwneeth nahwneeth commented Jun 23, 2023

  • Added slide in and out screen transitions.
  • Removed multiple BottomAppBarAll.
  • Added BottomNavActivity which holds the bottom navigation bar and uses a second NavHost to shows the screens.
  • Updated drawer to not open inbox, saved & profile as new screens.
  • CommunityListAcitivity does not show bottom nav bar when selecting a community for creating a post.
  • Tapping multiple times on a bottom nav tab doesn't open multiple views.
  • The selected icon is filled and the others are outlined.
  • Both the bottom nav bar and the navigation bar below it will always have the same color.
  • Back button isn't shown for screen opened from the bottom nav bar.
  • Fixed the bottom nav bar padding rising with the keyboard.

Closes #714
Closes #830

PS: This isn't a huge commit. The home activity has one less indent coz drawer was moved.

@nahwneeth nahwneeth changed the title Fix bottom nav bar Bottom nav bar and screen transitons Jun 23, 2023
@nahwneeth nahwneeth changed the title Bottom nav bar and screen transitons Bottom nav bar and screen transitions Jun 23, 2023
@twizmwazin
Copy link
Contributor

This change seems to conflict with the "Show navigation bar" option in settings. If this setting is disabled, there doesn't seem to be a way to navigate from search/inbox/saved/profile back to the home page. There is no back or drawer indicator on the page, and hitting back just exits the app.

@nahwneeth
Copy link
Contributor Author

I've restored the back button if bottom nav bar isn't shown.

@twizmwazin twizmwazin enabled auto-merge (squash) June 24, 2023 06:29
@twizmwazin twizmwazin merged commit 54a2e01 into LemmyNet:main Jun 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants