Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Copy post and comment information to clipboard #850

Merged
merged 5 commits into from
Jun 23, 2023
Merged

Copy post and comment information to clipboard #850

merged 5 commits into from
Jun 23, 2023

Conversation

Noxor11
Copy link
Contributor

@Noxor11 Noxor11 commented Jun 23, 2023 •
edited
Loading

Allows to copy the thumbnail url of a post if available, and copy a comment made to a post.

@MV-GH
Copy link
Collaborator

MV-GH commented Jun 23, 2023

The three composables are almost the change them into a generic something like MyThumbnailCopy and pass the differences as arguments

@Noxor11
Copy link
Contributor Author

Noxor11 commented Jun 23, 2023 •
edited
Loading

Comments don't have thumbnails, but I agree the common code should be contained in a method or class

twizmwazin
twizmwazin suggested changes Jun 23, 2023
View reviewed changes
Copy link
Contributor

@twizmwazin twizmwazin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One other thing, I'm noticing that the dialog is not being dismissed after selecting the added options. If you're feeling up to it, maybe add in the option to copy post text as well while we're here.

app/src/main/java/com/jerboa/util/ClipboardCopyHandler.kt Outdated Show resolved Hide resolved
app/src/main/java/com/jerboa/util/ClipboardCopyHandler.kt Outdated Show resolved Hide resolved
app/src/main/java/com/jerboa/ui/components/post/PostListing.kt Outdated Show resolved Hide resolved
app/src/main/res/values/strings.xml Outdated Show resolved Hide resolved
app/src/main/res/values/strings.xml Outdated Show resolved Hide resolved
app/src/main/res/values/strings.xml Outdated Show resolved Hide resolved
@Noxor11
Copy link
Contributor Author

Noxor11 commented Jun 23, 2023

I just realized there's an Utils file, so I used that to place the new function.
Now the popup gets dismissed after clicking, and added ability to copy title, name, and text from a post.

@Noxor11 Noxor11 requested a review from twizmwazin June 23, 2023 20:12
@Noxor11 Noxor11 changed the title copy thumbnail url if available and comment copy post and comment information to clipboard Jun 23, 2023
@Noxor11 Noxor11 changed the title copy post and comment information to clipboard Copy post and comment information to clipboard Jun 23, 2023
@twizmwazin twizmwazin enabled auto-merge (squash) June 23, 2023 22:22
@twizmwazin twizmwazin merged commit 243bc22 into LemmyNet:main Jun 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@twizmwazin twizmwazin twizmwazin approved these changes

@dessalines dessalines Awaiting requested review from dessalines dessalines is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Noxor11 @MV-GH @twizmwazin