Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix thumbnail links being treated as images. Fixes #815 #816

Merged
merged 1 commit into from
Jun 22, 2023
Merged

Conversation

dessalines
Copy link
Member

Somewhere along the line, clicking on thumbnail links got removed, and every thumbnail was treated as an image, even if it was a link post.

This fixes that by altering the thumbnail tile to check to see if the url is an image.

@dessalines dessalines requested a review from twizmwazin as a code owner June 22, 2023 12:46
navController = navController,
useCustomTab = useCustomTabs,
usePrivateTab = usePrivateTabs,
)
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Important code here.

@MV-GH
Copy link
Collaborator

MV-GH commented Jun 22, 2023

This 25d3f61 commit introduced this bug

Copy link
Contributor

@beatgammit beatgammit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

I wonder if we can turn on a lint for variable mutability.

@dessalines dessalines merged commit 2c25db2 into main Jun 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants