Russian translation & Fixes of non-localized strings #794
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MV-GH
reviewed
Jun 21, 2023
| <string name="inbox_activity_replies">Replies</string> | ||
| <string name="inbox_activity_mentions">Mentions</string> | ||
| <string name="inbox_activity_messages">Messages</string> | ||
| <string name="bookmarks_activity_saved">Saved</string> |
There was a problem hiding this comment.
There is already two Saved string resources, maybe use an existing? Or is it not applicable in this context?
There was a problem hiding this comment.
Probably. It is applicable in this context but there already were duplicating string resources previously for different contexts so i thought it would be better to separate them to leave some flexibility.
dessalines
reviewed
Jun 21, 2023
| @@ -103,7 +103,7 @@ fun PersonProfileActivity( | |||
| PersonProfileHeader( | |||
| scrollBehavior = scrollBehavior, | |||
| personName = if (savedMode) { | |||
| "Saved" | |||
| ctx.getString(R.string.bookmarks_activity_saved) | |||
|
Done, now it passes the check |
dessalines
approved these changes
Jun 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Translated app to russian and fixed some unlocalized string here and there