Use overloaded AndroidView in MarkdownHelper

[yate]

From what I've tested this mostly fixes #730. There's still a bit of a jerk upwards as the images loads in so it's not perfect, but it prevents the endless scroll downwards when hitting an image as shown in the issue.

I'm not entirely sure if anything needs to go in the onReset method, but it's noted in the Jetpack Compose documentation to use this overload with LazyColumns because the view can be reused during recomposition, so it may help with performance as well.

device-2023-06-19-225611.webm

[dessalines]

The example you linked shows that reset should include view.clear()

[yate]

I looked more into that example, and that clear() doesn't seem to do anything either

The documentation says the callback "may be used to reset any transient View state like animations or user input.". I don't think that applies here?

[ZJouba]

Okay, after taking a look in LayoutInspector, I believe this is caused by the View being reused and the image being discarded.

When the comment is inside the viewport everything looks fine, we can see the markdown helper in the AndroidView

However, when we scroll the image out of the viewport we see the AndroidView is empty

Then, I believe when it is scrolled back into view, the image gets reloaded and something forces the scroll to focus on the image. What's weird to me is that the height of the AndroidView remains constant at 504dp so why does the viewport suddenly jump to include the whole image? It's not a matter of layout shift.

[dessalines]

I'm sure its lazylist weirdness, might be worth trying to mess around with the markwon pictrs coil image sizes.

[ZJouba]

Tsk, this is what we need but it's not available for LazyColumn yet https://issuetracker.google.com/issues/172029355

[dessalines]

Not sure that this onReset will do anything, but I resolved the conflicts.