Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added close on click functionality to ImageViewerDialog. Solves #736 #738

Merged
merged 3 commits into from
Jun 19, 2023

Conversation

sockenklaus
Copy link
Contributor

@sockenklaus sockenklaus commented Jun 18, 2023

This closes #736

Copy link
Member

@dessalines dessalines left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dessalines dessalines merged commit ba8397c into LemmyNet:main Jun 19, 2023
@sockenklaus sockenklaus deleted the 736_close_image_viewer_on_tap branch June 19, 2023 13:10
@pipe01
Copy link
Contributor

pipe01 commented Jun 27, 2023

This means that you can no longer tap to toggle the top bar, double tap to quickly zoom in or double tap and drag do zoom in or out, and it adds an ugly white overlay on tap.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add action to tap to close image viewer
4 participants