Fix bug with pictrs url query param rewriting #735
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
beatgammit
force-pushed
the
bug/pictrs-url-query-params
branch
from
c6fe969 to
ff3d933
Compare
|
Its no problem, this wasn't deployed anyway. |
dessalines
approved these changes
Jun 19, 2023
sockenklaus
approved these changes
Jun 20, 2023
beatgammit
force-pushed
the
bug/pictrs-url-query-params
branch
from
ff3d933 to
0a4ad33
Compare
beatgammit
force-pushed
the
bug/pictrs-url-query-params
branch
from
0a4ad33 to
58dab75
Compare
dessalines
approved these changes
Jun 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apparently I broke stuff by trying to be fancy. I'm not really a fan of parsing the URL like this though, but at least there are test cases for it now.